Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parse_bytes imports to resolve deprecation warnings #662

Merged

Conversation

pentschev
Copy link
Member

Resolves deprecation warnings such as the one below:

FutureWarning: parse_bytes is deprecated and will be removed in a future release. Please use dask.utils.parse_bytes instead.
    from distributed.utils import parse_bytes

@pentschev pentschev requested a review from a team as a code owner June 28, 2021 16:15
@github-actions github-actions bot added the python python code needed label Jun 28, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Jun 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@939bc26). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2308b48 differs from pull request most recent head 6f5ea2f. Consider uploading reports for the commit 6f5ea2f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08     #662   +/-   ##
===============================================
  Coverage                ?   90.32%           
===============================================
  Files                   ?       15           
  Lines                   ?     1644           
  Branches                ?        0           
===============================================
  Hits                    ?     1485           
  Misses                  ?      159           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939bc26...6f5ea2f. Read the comment docs.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the code hygiene here.

@jacobtomlinson jacobtomlinson added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 29, 2021
@jacobtomlinson
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 66b7795 into rapidsai:branch-21.08 Jun 29, 2021
@pentschev
Copy link
Member Author

Thanks @jacobtomlinson for review!

@pentschev pentschev deleted the update-parse_bytes-deprecation branch June 29, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants