-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding profiling to dask shuffle #625
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
add to allowlist |
The CI failures here should be resolved by PR ( #623 ) and PR ( rapidsai/cudf#8342 ) |
Thanks, do I need to re-trigger the test? |
No we can do that. We just have to wait for those PRs to be merged |
Thanks @arunraman, good idea including profiling of the explicit-comms execution! Hope you don't mind, I took the liberty to move the profiling to include both the regular and the explicit-comms execution. |
rerun tests |
Still waiting on PR ( #623 ) before CI is fixed |
rerun tests |
@gpucibot merge |
BTW @arunraman, Dask's performance profile might not include the communication within the explict-comms tasks. @jakirkham do you know what the performance profile capture exactly? |
Performance profile will capture:
|
@quasiben, what about manually created endpoints: ep = await distributed.comm.connect(address) |
Adding benchmark profile for dask shuffle.