-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RTD site to redirect to RAPIDS docs #615
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #615 +/- ##
===============================================
Coverage ? 90.71%
===============================================
Files ? 15
Lines ? 1616
Branches ? 0
===============================================
Hits ? 1466
Misses ? 150
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @charlesbluca .
@jakirkham could you also take a look?
Yep looks good. Had one suggestion above. Thanks for working on this Charles 😄 |
Co-authored-by: jakirkham <[email protected]>
Thanks @jakirkham! Based on that suggestion, we should also probably update the copyright of the main docs as well - would you be okay with using copyright = "2020-%s, NVIDIA" % datetime.datetime.now().year |
Agreed that is better :) |
@gpucibot merge |
Manually started a build on RTD. Passed without issues. The redirect seems to be working 🎉 |
Thanks Charles! 😄 |
Updates docs copyright year with `datetime`, based on [#615 (comment)](#615 (comment)) Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - https://github.com/jakirkham URL: #616
Taking @jakirkham's suggestion for handling RTD redirects to an external site.