Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTD site to redirect to RAPIDS docs #615

Merged
merged 3 commits into from
May 19, 2021

Conversation

charlesbluca
Copy link
Member

@charlesbluca charlesbluca commented May 19, 2021

Taking @jakirkham's suggestion for handling RTD redirects to an external site.

@charlesbluca charlesbluca added python python code needed 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels May 19, 2021
@github-actions github-actions bot removed doc Documentation python python code needed labels May 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@83b065e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06     #615   +/-   ##
===============================================
  Coverage                ?   90.71%           
===============================================
  Files                   ?       15           
  Lines                   ?     1616           
  Branches                ?        0           
===============================================
  Hits                    ?     1466           
  Misses                  ?      150           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b065e...eb442a8. Read the comment docs.

@pentschev pentschev added the doc Documentation label May 19, 2021
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @charlesbluca .

@jakirkham could you also take a look?

rtd/conf.py Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Yep looks good. Had one suggestion above. Thanks for working on this Charles 😄

Co-authored-by: jakirkham <[email protected]>
@github-actions github-actions bot removed the doc Documentation label May 19, 2021
@charlesbluca
Copy link
Member Author

Thanks @jakirkham! Based on that suggestion, we should also probably update the copyright of the main docs as well - would you be okay with using datetime to update this automatically? Something like

copyright = "2020-%s, NVIDIA" % datetime.datetime.now().year

@jakirkham
Copy link
Member

Agreed that is better :)

@jakirkham jakirkham added the doc Documentation label May 19, 2021
@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 595427b into rapidsai:branch-21.06 May 19, 2021
@jakirkham
Copy link
Member

Manually started a build on RTD. Passed without issues. The redirect seems to be working 🎉

@jakirkham
Copy link
Member

Thanks Charles! 😄

rapids-bot bot pushed a commit that referenced this pull request May 20, 2021
Updates docs copyright year with `datetime`, based on [#615 (comment)](#615 (comment))

Authors:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

Approvers:
  - https://github.com/jakirkham

URL: #616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants