Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DGX tests for UCX 1.10+ #613

Merged
merged 1 commit into from
May 19, 2021
Merged

Fix DGX tests for UCX 1.10+ #613

merged 1 commit into from
May 19, 2021

Conversation

pentschev
Copy link
Member

Fix a couple more tests for UCX 1.10.

@pentschev pentschev requested a review from a team as a code owner May 19, 2021 16:09
@github-actions github-actions bot added the python python code needed label May 19, 2021
@quasiben quasiben added the non-breaking Non-breaking change label May 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@cbb677c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06     #613   +/-   ##
===============================================
  Coverage                ?   61.64%           
===============================================
  Files                   ?       21           
  Lines                   ?     2581           
  Branches                ?        0           
===============================================
  Hits                    ?     1591           
  Misses                  ?      990           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb677c...cf18557. Read the comment docs.

quasiben
quasiben approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quasiben quasiben added the improvement Improvement / enhancement to an existing function label May 19, 2021
@quasiben
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 83b065e into rapidsai:branch-21.06 May 19, 2021
@pentschev pentschev mentioned this pull request May 21, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request May 21, 2021
@pentschev
Fix DGX tests for UCX 1.9 (#619)
c158d9c 
I accidentally broke DGX tests when using UCX 1.9 in #613, this PR fixes that.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #619
@pentschev pentschev deleted the fix-dgx-tests branch May 26, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @codecov-commenter @quasiben