-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UCX documentation and examples #545
Improve UCX documentation and examples #545
Conversation
Thinking that the UCX usage sections could probably be simplified a bit if we better fleshed out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments here @charlesbluca , but it's looking good so far, thanks for working on this!
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #545 +/- ##
================================================
+ Coverage 62.37% 92.27% +29.89%
================================================
Files 22 16 -6
Lines 2517 1605 -912
================================================
- Hits 1570 1481 -89
+ Misses 947 124 -823
Continue to review full report at Codecov.
|
Thanks for the review @pentschev! Addressed them as best I could. I reorganized the use cases into a general "Usage" section and consolidated most of the information on client setup to an individual "Client" section that showcases |
Is there anything we can do with the API reference to make |
Made some changes to the API source so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca , this is looking good so far!
I added a few minor suggestions and replied most of your questions (if I missed any, please let me know).
Since this is getting larger than I initially predicted, what do you say we merge this after my comments are addressed and continue with samples in a follow-up PR? I generally think this is better to avoid getting PRs too large and increasingly more difficult to track changes.
- dask_cuda.initialize | ||
|
||
See https://docs.dask.org/en/latest/configuration.html for more information | ||
about Dask configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a note here now to let users know that this is already done for LocalCUDACluster
(including the client, if it's instantiated on the same process as the cluster) and dask-cuda-worker
, so users don't need to do that again. The common place where users would want to use this is when they instantiate their standalone client connecting to a cluster that has already been started with a combination of dask-scheduler
/dask-cuda-worker
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, in that case I will emphasize in the docstring that this script is meant for use with the client to mirror the pre-configured CUDA cluster/workers, and that the worker preload script would only need to be used with mainline Dask/Distributed.
Addressed your comments - let me know if I should change anything. If not, I'm happy to merge and handle the examples in a separate PR! Thanks for the help 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small change, then I think we can merge it, but we're still blocked by #546.
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @charlesbluca for the work on improving docs here!
@gpucibot merge |
Following up on #545, this PR adds standalone examples of UCX usage to a new `examples/ucx/` directory. Right now, these are pretty simple - just showing cluster, worker, and client setups for NVLink, InfiniBand, both, or neither. I imagine there are problem some more complicated/niche set up we could showcase here. cc @pentschev Authors: - Charles Blackmon-Luca (@charlesbluca) Approvers: - Peter Andreas Entschev (@pentschev) URL: #551
Addressing #544, this PR aims to clarify the requirements, configuration, and usage of UCX with Dask-CUDA.
Still a lot to be done: