Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxifyHostFile: tracking of external objects #527

Merged
merged 13 commits into from
Feb 25, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Feb 16, 2021

This PR implements tracking of external objects. The idea is that tasks can register objects that should be exposed to spilling when ProxifyHostFile is running out of memory.

Also, this PR makes the long running explicit-comms tasks local_shuffle() use this new feature, which means it shouldn't require more GPU memory than the regular shuffle implementation in Dask.

@madsbk madsbk added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 16, 2021
@madsbk madsbk force-pushed the proxify_external_tracking branch from 196b5b6 to 255a18f Compare February 17, 2021 12:33
@github-actions github-actions bot added the python python code needed label Feb 18, 2021
@madsbk madsbk force-pushed the proxify_external_tracking branch 2 times, most recently from 21c153d to d5ea45e Compare February 18, 2021 12:21
@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #527 (2eb4acb) into branch-0.19 (a574ccb) will increase coverage by 30.50%.
The diff coverage is 92.30%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-0.19     #527       +/-   ##
================================================
+ Coverage        61.90%   92.41%   +30.50%     
================================================
  Files               22       16        -6     
  Lines             2452     1595      -857     
================================================
- Hits              1518     1474       -44     
+ Misses             934      121      -813     
Impacted Files Coverage Δ
dask_cuda/proxify_device_objects.py 88.52% <69.23%> (+6.89%) ⬆️
dask_cuda/explicit_comms/dataframe/shuffle.py 98.61% <100.00%> (+0.83%) ⬆️
dask_cuda/proxify_host_file.py 100.00% <100.00%> (ø)
dask_cuda/proxy_object.py 91.26% <100.00%> (+1.18%) ⬆️
dask_cuda/_version.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cudf_merge.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a574ccb...bc67216. Read the comment docs.

@madsbk madsbk force-pushed the proxify_external_tracking branch from 7842f31 to bd5df7b Compare February 19, 2021 14:41
@madsbk madsbk force-pushed the proxify_external_tracking branch from bd5df7b to bc67216 Compare February 19, 2021 14:54
@madsbk
Copy link
Member Author

madsbk commented Feb 19, 2021

@beckernick @VibhuJawa, it would be great if one of you have time try this PR. You need to set DASK_JIT_UNSPILL=True and DASK_EXPLICIT_COMMS=True.

@madsbk madsbk added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 22, 2021
@madsbk madsbk marked this pull request as ready for review February 22, 2021 08:21
@madsbk madsbk requested a review from a team as a code owner February 22, 2021 08:21
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions here, but overall LGTM.

dask_cuda/proxify_device_objects.py Show resolved Hide resolved
dask_cuda/proxify_device_objects.py Show resolved Hide resolved
dask_cuda/proxify_host_file.py Outdated Show resolved Hide resolved
dask_cuda/proxy_object.py Show resolved Hide resolved
dask_cuda/tests/test_proxify_host_file.py Show resolved Hide resolved
@madsbk
Copy link
Member Author

madsbk commented Feb 23, 2021

Thanks for the review @pentschev, I think I have addressed all of your concerns. Also added some overall description: c6321bd

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk !

@pentschev pentschev added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 23, 2021
@pentschev
Copy link
Member

If there's no rush, I would wait another day to see if @beckernick or @VibhuJawa have a chance to try out the PR, otherwise it can be merged any time IMO.

@madsbk
Copy link
Member Author

madsbk commented Feb 25, 2021

Since explicit-comms's shuffle is disabled by default, I think it is safe to merge.

@gpucibot merge

@madsbk
Copy link
Member Author

madsbk commented Feb 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 71f3d8d into rapidsai:branch-0.19 Feb 25, 2021
@pentschev
Copy link
Member

Thanks @madsbk !

@madsbk madsbk deleted the proxify_external_tracking branch April 27, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants