Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci] #520

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

GPUtester
Copy link
Contributor

Auto-merge triggered by push to branch-0.18 that creates a PR to keep branch-0.19 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

The way the code was written would pass the client's device to each worker and synchronize on that, which is wrong. This was catched due to recent changes to Distributed, where the following was raised:

```python
Task exception was never retrieved
future: <Task finished coro=<Scheduler.broadcast.<locals>.send_message() done, defined at /datasets/pentschev/miniconda3/envs/gdf/lib/python3.7/site-packages/distributed/scheduler.py:4965> exception=Exception("unhashable type: 'cupy.cuda.device.Device'")>
Traceback (most recent call last):
  File "/datasets/pentschev/miniconda3/envs/gdf/lib/python3.7/site-packages/distributed/scheduler.py", line 4969, in send_message
    resp = await send_recv(comm, close=True, serializers=serializers, **msg)
  File "/datasets/pentschev/miniconda3/envs/gdf/lib/python3.7/site-packages/distributed/core.py", line 662, in send_recv
    raise Exception(response["text"])
Exception: unhashable type: 'cupy.cuda.device.Device'
```

Authors:
  - Peter Andreas Entschev (@pentschev)

Approvers:
  - Benjamin Zaitlen (@quasiben)

URL: #518
@GPUtester GPUtester requested a review from a team as a code owner February 9, 2021 19:08
@GPUtester GPUtester merged commit 0751c4b into branch-0.19 Feb 9, 2021
@GPUtester
Copy link
Contributor Author

SUCCESS - Auto-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants