Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore legacy Dask dataframe warnings #1397

Merged

Conversation

pentschev
Copy link
Member

Ignore legacy Dask dataframe warnings that the implementation is going to be soon removed, introduced in
dask/dask#11437 .

The warning is only raised for DASK_DATAFRAME__QUERY_PLANNING=False cases.

Ignore legacy Dask dataframe warnings that the implementation is going
to be soon removed, introduced in
dask/dask#11437 .

The warning is only raised for `DASK_DATAFRAME__QUERY_PLANNING=False`
cases.
@pentschev pentschev requested a review from a team as a code owner October 22, 2024 09:14
@pentschev pentschev requested a review from AyodeAwe October 22, 2024 09:14
@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 22, 2024
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev !

@pentschev
Copy link
Member Author

Thanks @rjzamora for approving.

@pentschev
Copy link
Member Author

/merge

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, especially since it's the same thing cudf did: rapidsai/cudf#17137

@pentschev
Copy link
Member Author

This looks fine to me, especially since it's the same thing cudf did: rapidsai/cudf#17137

Exactly, it is the same thing, I should have mentioned that.

@jameslamb jameslamb removed the request for review from AyodeAwe October 22, 2024 16:44
@rapids-bot rapids-bot bot merged commit 0f78f5d into rapidsai:branch-24.12 Oct 22, 2024
28 checks passed
@pentschev pentschev deleted the ignore-legacy-dataframe-warning branch October 23, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants