Skip TCP-only DGX tests with UCX 1.16 #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wireup may fail in UCX 1.16 in nodes with multiple NICs if TCP is used, thus skip those tests. UCX 1.17 will resolve the issue, and alternatively `UCX_PROTO_ENABLE=n` may be used in UCX 1.16 as well.
pentschev
added
bug
rjzamora
reviewed
Apr 8, 2024
dask_cuda/tests/test_dgx.py
Outdated
| ucp = pytest.importorskip("ucxx") | ||
| if _is_ucx_116(ucp): | ||
| pytest.skip( | ||
| "Wireup may fail in UCX 1.16 in nodes with multiple NICs if TCP is used" |
There was a problem hiding this comment.
Is there an Issue we can link to for the new skip logic?
There was a problem hiding this comment.
There wasn't one, I've filed rapidsai/ucx-py#1037 to fill that gap and changed the skip message to point to that link via b0a86ab .
rjzamora
approved these changes
Apr 8, 2024
|
Thanks @rjzamora ! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wireup may fail in UCX 1.16 in nodes with multiple NICs if TCP is used, thus skip those tests. UCX 1.17 will resolve the issue, and alternatively
UCX_PROTO_ENABLE=nmay be used in UCX 1.16 as well.