Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add ci scripts & conda recipe #13

Merged
merged 4 commits into from
Mar 15, 2019
Merged

[REVIEW] Add ci scripts & conda recipe #13

merged 4 commits into from
Mar 15, 2019

Conversation

raydouglass
Copy link
Member

No description provided.

@raydouglass raydouglass requested a review from mrocklin March 13, 2019 23:18
@mrocklin mrocklin requested a review from jakirkham March 13, 2019 23:25
@mrocklin
Copy link
Contributor

cc'd @jakirkham , who knows much more than I do about packaging :)

@mike-wendt mike-wendt changed the base branch from master to branch-0.6 March 14, 2019 05:11
dillon-cullinan
dillon-cullinan reviewed Mar 15, 2019
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
kkraus14
kkraus14 suggested changes Mar 15, 2019
View reviewed changes
Copy link

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes needed. Also, given this is a pure python package I believe we can build once and upload to all of the channels as opposed to needing to build multiple times, but that can be streamlined later.

mtjrider
mtjrider approved these changes Mar 15, 2019
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/cpu/upload-anaconda.sh Outdated Show resolved Hide resolved
setup.py
@@ -20,8 +23,8 @@
"Topic :: Database",
"Topic :: Scientific/Engineering",
"License :: OSI Approved :: Apache License",
"Programming Language :: Python :: 3.5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@raydouglass raydouglass requested a review from kkraus14 March 15, 2019 01:06
kkraus14
kkraus14 approved these changes Mar 15, 2019
View reviewed changes
Copy link

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@raydouglass raydouglass merged commit a0b523b into rapidsai:branch-0.6 Mar 15, 2019
@jakirkham
Copy link
Member

jakirkham commented Mar 15, 2019 •
edited
Loading

Thanks for working on this all. Sorry to get to reviewing it late (was flying back across the country). Added a small tweak in PR ( #15 ).

There are some other things that would be good to discuss about conda packaging (mostly due to improvements in conda and conda-build over the years). Though we can save this discussion until after things have cooled down a bit.

Edit: Raised issue ( rapidsai/cudf#1210 ) about the other conda packaging things that come to mind.

@pentschev pentschev mentioned this pull request Jun 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillon-cullinan dillon-cullinan dillon-cullinan left review comments

@rlratzel rlratzel rlratzel left review comments

@mrocklin mrocklin mrocklin left review comments

@mtjrider mtjrider mtjrider approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@jakirkham jakirkham Awaiting requested review from jakirkham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@raydouglass @mrocklin @jakirkham @rlratzel @kkraus14 @mtjrider @dillon-cullinan