Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Nanny close timeout for test_spilling_local_cuda_cluster #1289

Merged

Conversation

pentschev
Copy link
Member

Increase Nanny close timeout for test_spilling_local_cuda_cluster which didn't fail in the past but failed for the first time in latest nightly run.

@pentschev pentschev requested a review from a team as a code owner December 1, 2023 08:13
@github-actions github-actions bot added the python python code needed label Dec 1, 2023
@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Dec 1, 2023
@pentschev
Copy link
Member Author

For reference, the nightly run where this failed: https://github.com/rapidsai/dask-cuda/actions/runs/7053635426/job/19201061074 .

Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this target 24.02?

@pentschev
Copy link
Member Author

Should this target 24.02?

We're still running nightlies with 23.12, thus I think it makes sense to fix this still in the 23.12 branch.

@raydouglass raydouglass merged commit 1962e2d into rapidsai:branch-23.12 Dec 1, 2023
22 of 23 checks passed
@pentschev pentschev deleted the test-increase-nanny-close-timeout branch January 4, 2024 08:24
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
…apidsai#1289)

Increase Nanny close timeout for `test_spilling_local_cuda_cluster` which didn't fail in the past but failed for the first time in latest nightly run.

Authors:
   - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
   - Richard (Rick) Zamora (https://github.com/rjzamora)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants