Set minimum click to 8.1 #1272
Merged
Set minimum click to 8.1 #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
added
bug
|
I think this shouldn't be necessary anymore if dask/dask#10623 gets merged, right @jacobtomlinson ? |
|
That is true, but that relies on us moving our pin to whatever Dask release contains that change. If we've already pinned Dask for 23.12 I would be tempted to merge this in here still. |
|
Let's get this merged in for 23.12 |
|
@jacobtomlinson can you merge with main and resolve the conflict with pyproject.toml and then we should be good |
|
I fixed the merge conflict, let's see if things run |
quasiben
approved these changes
Nov 20, 2023
|
/merge |
Merged
younseojava
pushed a commit
to ROCm/dask-cuda-rocm
that referenced
this pull request
Apr 16, 2024
Closes rapidsai#1271 Authors: - Jacob Tomlinson (https://github.com/jacobtomlinson) - Lawrence Mitchell (https://github.com/wence-) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: rapidsai#1272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1271