-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increate timeouts of tests that frequently timeout in CI #1228
Increate timeouts of tests that frequently timeout in CI #1228
Conversation
Sample of such timeouts can be seen in yesterday's nightly tests. |
More examples of timeouts from last night: https://github.com/rapidsai/dask-cuda/actions/runs/6008227979/attempts/1 |
Those timeouts sadly still persist in this PR. Do we need to bump them further? |
I'm setting up locally to see if I can reproduce them and how long the average runtime seems to be on our systems. I'm wondering if this is only the timeout or there's something else hidden under the timeout error. |
Or perhaps an easier and more accurate way to measure this is to (maybe temporarily) increase timeouts further and print durations of all tests in CI. |
Of course, now that the timeout has been increased there's nothing unusual, with What do you think we should do here @wence- ? |
That sounds like a reasonable approach, yes. |
Alright then, should we merge it as is then? I'll keep an eye for tonight's run and see what I can find out. |
/merge |
1 similar comment
/merge |
@wence- was trying to get this merged today but it seems today's not the day to merge it. 😞 |
In the past few weeks some tests have timed out with certain frequency in CI, probably due to its load. Attempt to avoid those by increasing timeouts from 20 to 30 seconds.