Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying dashboard address in benchmarks #1147

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Allow specifying dashboard address in benchmarks #1147

merged 1 commit into from
Mar 30, 2023

Conversation

pentschev
Copy link
Member

This is useful for shared machines where the user may not have control of the default port 8787.

@pentschev pentschev requested a review from a team as a code owner March 29, 2023 14:01
@github-actions github-actions bot added the python python code needed label Mar 29, 2023
@pentschev pentschev added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Mar 29, 2023
wence-
wence- approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jacobtomlinson
jacobtomlinson approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pentschev
Copy link
Member Author

Thanks @wence- @jacobtomlinson !

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a51b10b into rapidsai:branch-23.04 Mar 30, 2023
@pentschev pentschev deleted the benchmarks-dashboard-address branch May 15, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @wence- @jacobtomlinson