Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize of ProxyObject to pickle fixed attributes #1137

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Serialize of ProxyObject to pickle fixed attributes #1137

merged 1 commit into from
Mar 6, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Mar 1, 2023 •
edited
Loading

The proxied's name attribute might contain types not support by msgpack. We now pickle the fixed attributes when serializing.

Closes #1136

@madsbk madsbk added bug Something isn't working non-breaking Non-breaking change labels Mar 1, 2023
@github-actions github-actions bot added the python python code needed label Mar 1, 2023
@madsbk madsbk changed the title Serialize of ProxyObject now pickles "obj-pxy-detail" Serialize of ProxyObject to pickle fixed attributes Mar 1, 2023
@madsbk madsbk mentioned this pull request Mar 1, 2023
Closed
@madsbk madsbk marked this pull request as ready for review March 1, 2023 11:22
@madsbk madsbk requested a review from a team as a code owner March 1, 2023 11:22
wence-
wence- approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I think. Let us wait for confirmation that this fixes the issue.

pentschev
pentschev approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, jobs seem to have failed due to a timeout on pulling conda packages, I've restarted them.

@pentschev
Copy link
Member

Seems like there is something going on with CI, I've asked our ops team to take a look.

@pentschev
Copy link
Member

All tests are passing now, merging. Thanks @madsbk !

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 64a92a1 into rapidsai:branch-23.04 Mar 6, 2023
@madsbk madsbk deleted the proxy_object_pickle_obj-pxy-detail branch March 27, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dask-Cudf + XGBoost fails with jit_unspill=True
3 participants
@madsbk @pentschev @wence-