Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHA build workflow #1120

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix GHA build workflow #1120

merged 2 commits into from
Feb 23, 2023

Conversation

AjayThorve
Copy link
Member

This PR fixes the condition to trigger docs-build workflow in build.yaml to:

  • simplify the branch assertion
  • ensure that it only runs on push events (as opposed to workflow_dispatch events which trigger the nightlies).

@ajschmidt8

@AjayThorve AjayThorve requested a review from a team as a code owner February 17, 2023 17:25
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2023
@ajschmidt8
Copy link
Member

/merge

@ajschmidt8
Copy link
Member

@pentschev, can you help us get this PR over the finish line?

It looks like we're seeing some test failures that are unrelated to our changes.

You can check out the failure summary here: https://github.com/rapidsai/dask-cuda/actions/runs/4206074581/attempts/3#summary-11426863398

I've rerun the failed job 3 times (a 4th run is in progress), but it seems that the failures are pretty consistent.

@ajschmidt8 ajschmidt8 mentioned this pull request Feb 23, 2023
Merged
@jakirkham
Copy link
Member

Peter's OOTO atm. Maybe @wence- would be able to help?

@ajschmidt8
Copy link
Member

@jakirkham, looks like #1128 should resolve the issue.

I've just merged the latest changes into this PR which should get it passing.

@rapids-bot rapids-bot bot merged commit 458655d into rapidsai:branch-23.04 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AjayThorve @ajschmidt8 @jakirkham