Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Unpin dask and distributed for development #1110

Merged
merged 2 commits into from
Feb 10, 2023
Merged

[REVIEW] Unpin dask and distributed for development #1110

merged 2 commits into from
Feb 10, 2023

Conversation

galipremsagar
Copy link
Contributor

This PR unpins dask and distributed for 23.04 development.

xref: rapidsai/cudf#12710

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 6, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner February 6, 2023 19:31
@galipremsagar galipremsagar self-assigned this Feb 6, 2023
@github-actions github-actions bot added the gpuCI gpuCI issue label Feb 6, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@014d588). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.04    #1110   +/-   ##
===============================================
  Coverage                ?   87.91%           
===============================================
  Files                   ?       17           
  Lines                   ?     2300           
  Branches                ?        0           
===============================================
  Hits                    ?     2022           
  Misses                  ?      278           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pentschev
pentschev requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, nothing has changed w.r.t. the procedure, right? We still need to wait for the actual 23.02 to release before merging this, otherwise forward merge will revert this change. Blocking for now, but please correct me if anything has changed and this can be merged immediately.

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Feb 6, 2023 •
edited
Loading

Just to be sure, nothing has changed w.r.t. the procedure, right? We still need to wait for the actual 23.02 to release before merging this, otherwise forward merge will revert this change. Blocking for now, but please correct me if anything has changed and this can be merged immediately.

I don't think merging branch-23.02 to main(i.e., a release) will trigger another forward merge to branch-23.04.

cc: @ajschmidt8 | @raydouglass incase that's changed.

Update: Discussed offline with @pentschev and decided to hold off merging.

@galipremsagar galipremsagar added the DO NOT MERGE Hold off on merging; see PR for details label Feb 6, 2023
@pentschev
Copy link
Member

Just to clarify my previous comment: forward merge may revert this change, if any changes are merged into 23.02 before release.

@galipremsagar galipremsagar removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 9, 2023
pentschev
pentschev approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

@galipremsagar galipremsagar added DO NOT MERGE Hold off on merging; see PR for details and removed DO NOT MERGE Hold off on merging; see PR for details labels Feb 10, 2023
@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b0e4f2d into rapidsai:branch-23.04 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@pentschev pentschev pentschev approved these changes

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @codecov-commenter @pentschev @raydouglass