-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicit-comms: don't mix -
and _
in config
#1096
Conversation
Codecov ReportBase: 87.90% // Head: 87.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1096 +/- ##
================================================
+ Coverage 87.90% 87.91% +0.01%
================================================
Files 17 17
Lines 2298 2300 +2
================================================
+ Hits 2020 2022 +2
Misses 278 278
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @madsbk , but I think there's room to improve how explicit comms are organized. WDYT?
batchsize = batchsize or dask.config.get("explicit_comms-batchsize", 1) | ||
batchsize = batchsize or dask.config.get("explicit-comms-batchsize", 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given there are multiple properties for explicit-comms
(i.e., explicit-comms
and explicit-comms-batchsize
), I think it would make sense to make that a collection, e.g., explicit-comms.enable
and explicit-comms.batchsize
, or something analogous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I advocated for this in a previous PR, so I am in favour of this idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, yes @wence- had the exact same suggestion: #1068 (comment) :)
I will change to explicit-comms.enable
in a follow up PR
/merge |
Using
dask.config.get("explicit_comms-batchsize", 1)
doesn't readDASK_EXPLICIT_COMMS_BATCHSIZE
correctly.