Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace & add URLs in pyproject.toml #1092

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Fix whitespace & add URLs in pyproject.toml #1092

merged 2 commits into from
Jan 25, 2023

Conversation

jakirkham
Copy link
Member

No description provided.

@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 25, 2023
@jakirkham jakirkham changed the title Fix minor whitespace issues in pyproject.toml Fix whitespace & add URLs in pyproject.toml Jan 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023 •
edited
Loading

Codecov Report

Base: 87.90% // Head: 87.90% // No change to project coverage 👍

Coverage data is based on head (ec5aa4c) compared to base (66a6a46).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-23.02    #1092   +/-   ##
=============================================
  Coverage         87.90%   87.90%           
=============================================
  Files                17       17           
  Lines              2298     2298           
=============================================
  Hits               2020     2020           
  Misses              278      278

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pentschev
pentschev approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM John. Are those just formatting fixes or do they get raised as errors and do not allow building in some specific scenario? In the latter case, should we look for a pre-commit hook to correctly parse that file?

@jakirkham
Copy link
Member Author

No issues that I'm aware of. Just happened to spot them

@pentschev
Copy link
Member

Thanks @jakirkham !

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9ff3996 into rapidsai:branch-23.02 Jan 25, 2023
@jakirkham jakirkham deleted the fix_pyproj_fmt branch January 25, 2023 07:46
@jakirkham
Copy link
Member Author

Thanks Peter! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @codecov-commenter @pentschev