-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit: spell, whitespace, and mypy check #1091
pre-commit: spell, whitespace, and mypy check #1091
Conversation
Codecov ReportBase: 87.90% // Head: 87.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1091 +/- ##
=============================================
Coverage 87.90% 87.90%
=============================================
Files 17 17
Lines 2298 2298
=============================================
Hits 2020 2020
Misses 278 278
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @madsbk . What's the idea moving forward, make mypy strict?
I think the first step is to install all the library stubs in CI. Currently, a lot of the code is ignored. |
If we're using |
/merge |
close #1077