Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: spell, whitespace, and mypy check #1091

Merged

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jan 24, 2023

close #1077

@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2023
@github-actions github-actions bot added the python python code needed label Jan 24, 2023
@madsbk madsbk changed the title pre-commit: spell and whitespace check pre-commit: spell, whitespace, and mypy check Jan 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Base: 87.90% // Head: 87.90% // No change to project coverage 👍

Coverage data is based on head (072d5d4) compared to base (4f0922c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #1091   +/-   ##
=============================================
  Coverage         87.90%   87.90%           
=============================================
  Files                17       17           
  Lines              2298     2298           
=============================================
  Hits               2020     2020           
  Misses              278      278           
Impacted Files Coverage Δ
dask_cuda/cli.py 86.40% <ø> (ø)
dask_cuda/disk_io.py 56.19% <ø> (ø)
dask_cuda/explicit_comms/dataframe/shuffle.py 98.67% <ø> (ø)
dask_cuda/initialize.py 87.23% <ø> (ø)
dask_cuda/is_spillable_object.py 84.37% <ø> (ø)
dask_cuda/proxy_object.py 90.52% <ø> (ø)
dask_cuda/utils.py 83.47% <ø> (ø)
dask_cuda/proxify_device_objects.py 97.32% <100.00%> (ø)
dask_cuda/proxify_host_file.py 93.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madsbk madsbk marked this pull request as ready for review January 24, 2023 14:13
@madsbk madsbk requested a review from a team as a code owner January 24, 2023 14:13
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk . What's the idea moving forward, make mypy strict?

@madsbk
Copy link
Member Author

madsbk commented Jan 30, 2023

LGTM, thanks @madsbk . What's the idea moving forward, make mypy strict?

I think the first step is to install all the library stubs in CI. Currently, a lot of the code is ignored.

@wence-
Copy link
Contributor

wence- commented Jan 30, 2023

LGTM, thanks @madsbk . What's the idea moving forward, make mypy strict?

I think the first step is to install all the library stubs in CI. Currently, a lot of the code is ignored.

If we're using pre-commit, then we need to specify the extra packages in the pre-commit environment, so they all need to be pip installable (which might be problematic?)

@madsbk
Copy link
Member Author

madsbk commented Jan 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit 43969d7 into rapidsai:branch-23.02 Jan 30, 2023
@madsbk madsbk deleted the pre_commit_spill_and_whitespace branch January 30, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI: mypy check
4 participants