Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shuffle: use cuDF's partition_by_hash() when available #1090

Merged
merged 2 commits into from
Jan 23, 2023
Merged

shuffle: use cuDF's partition_by_hash() when available #1090

merged 2 commits into from
Jan 23, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jan 20, 2023 •
edited
Loading

cuDF's partition_by_hash() is faster than calling compute_map_index() followed by scatter_by_map().

Depend on rapidsai/cudf#12554

@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 20, 2023
@github-actions github-actions bot added the python python code needed label Jan 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023 •
edited
Loading

Codecov Report

Base: 87.89% // Head: 87.90% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (24ece9f) compared to base (03e5dcc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #1090      +/-   ##
================================================
+ Coverage         87.89%   87.90%   +0.01%     
================================================
  Files                17       17              
  Lines              2296     2298       +2     
================================================
+ Hits               2018     2020       +2     
  Misses              278      278
Impacted Files Coverage Δ
dask_cuda/explicit_comms/dataframe/shuffle.py 98.67% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madsbk madsbk marked this pull request as ready for review January 20, 2023 14:51
@madsbk madsbk requested a review from a team as a code owner January 20, 2023 14:51
pentschev
pentschev approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk .

@madsbk
Copy link
Member Author

madsbk commented Jan 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 963b745 into rapidsai:branch-23.02 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-commenter @pentschev