Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shuffle-benchmark #1074

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Improve shuffle-benchmark #1074

merged 13 commits into from
Jan 10, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jan 6, 2023 •
edited
Loading

Adding --ignore-index and balance the partition distribution between workers.

This should make the runs more consist and improve the data creation significantly.

@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 6, 2023
@github-actions github-actions bot added the python python code needed label Jan 6, 2023
@madsbk madsbk marked this pull request as ready for review January 6, 2023 15:28
@madsbk madsbk requested a review from a team as a code owner January 6, 2023 15:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023 •
edited
Loading

Codecov Report

Base: 87.17% // Head: 87.17% // No change to project coverage 👍

Coverage data is based on head (8ac2145) compared to base (74b4557).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-23.02    #1074   +/-   ##
=============================================
  Coverage         87.17%   87.17%           
=============================================
  Files                18       18           
  Lines              2253     2253           
=============================================
  Hits               1964     1964           
  Misses              289      289
Impacted Files Coverage Δ
dask_cuda/explicit_comms/comms.py 99.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pentschev
pentschev reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsbk , left a few suggestions/questions.

dask_cuda/benchmarks/local_cudf_shuffle.py Outdated Show resolved Hide resolved
dask_cuda/benchmarks/local_cudf_shuffle.py Outdated Show resolved Hide resolved
dask_cuda/benchmarks/local_cudf_shuffle.py Outdated Show resolved Hide resolved
wence-
wence- requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibbles (mostly around wording), but otherwise looks good.

dask_cuda/benchmarks/local_cudf_shuffle.py Outdated Show resolved Hide resolved
dask_cuda/benchmarks/local_cudf_shuffle.py Show resolved Hide resolved
dask_cuda/benchmarks/local_cudf_shuffle.py Outdated Show resolved Hide resolved
dask_cuda/benchmarks/local_cudf_shuffle.py Outdated Show resolved Hide resolved
@madsbk
Copy link
Member Author

madsbk commented Jan 9, 2023

Thanks for the reviews guys, anything else?

@madsbk madsbk requested review from wence- and pentschev January 9, 2023 19:20
pentschev
pentschev approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk . Will leave it open for @wence- final approval as well.

wence-
wence- approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@madsbk
Copy link
Member Author

madsbk commented Jan 10, 2023

/merge

@rapids-bot rapids-bot bot merged commit bdb7b56 into rapidsai:branch-23.02 Jan 10, 2023
@madsbk madsbk deleted the shuffle-benchmark-balance branch January 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madsbk @codecov-commenter @wence- @pentschev