Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions Workflows #1062
Add GitHub Actions Workflows #1062
Changes from 37 commits
56f84a4
47678e8
f645d8a
151568f
dbfeb96
52fe124
6ea6272
b89b7f8
4503a1f
7737c68
5bf3c68
05b601c
712b565
18412ae
c49f3a6
d5c08da
20b154b
1d2b497
a0e2299
bb0e90f
1461cb3
2dbeb2c
9145f2a
ef673b9
1e4dad2
8e4cfbb
8a07c21
5840b12
de20ceb
7c2b129
c7c484f
2e2c9d9
e681811
6ae8ccb
6c9d26e
d9af730
297accb
0b874d3
2a3eaff
80bf6db
5712a8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For parity with the Jenkins setup, we should only publish this once a day (at night).
We'll also need to add this repo to the RAPIDS nightly pipeline below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only capture the latest error, which may or may not be fine depending on how this is handled outside. Since we can't return multiple error codes on a single script, I think it might make sense to:
pytest
and two benchmarks); or0
for "success" and1
for "error(s) occurred").There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have plans to revisit and simplify some of this logic in follow-up PRs, but ultimately I think we only care to distinguish zero (success) from non-zero (failure) exit codes for the purposes of GitHub Actions calling this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand probably now we are sure that
CONDA_PY
is set, but what if there's a regression, wouldn't be better to keep a safe default like other variables have?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is set by conda, not by RAPIDS. This should be safe -- and if it's not, we want to have a hard failure. Also we want to avoid setting defaults that need continually updated in the recipes as we change Python version support.