Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Dask nightly last in CI #1029

Merged

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Nov 1, 2022

By installing Dask nightly as last step in CI, we prevent any other steps from inadvertently downgrading it before running tests.

@pentschev pentschev added 2 - In Progress Currently a work in progress non-breaking Non-breaking change gpuCI gpuCI issue labels Nov 1, 2022
@pentschev pentschev force-pushed the install-dask-nightly-last branch from a2d0c31 to 6e4c9cf Compare November 1, 2022 21:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (0133a2e) compared to base (3e5a19b).
Patch has no changes to coverable lines.

❗ Current head 0133a2e differs from pull request most recent head 6e4c9cf. Consider uploading reports for the commit 6e4c9cf to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-22.12   #1029     +/-   ##
==============================================
  Coverage          0.00%   0.00%             
==============================================
  Files                25      17      -8     
  Lines              3321    2216   -1105     
==============================================
+ Misses             3321    2216   -1105     
Impacted Files Coverage Δ
dask_cuda/_version.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/common.py
dask_cuda/benchmarks/local_cudf_groupby.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cudf_shuffle.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pentschev pentschev added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 1, 2022
@pentschev pentschev marked this pull request as ready for review November 1, 2022 22:31
@pentschev pentschev requested a review from a team as a code owner November 1, 2022 22:31
@pentschev pentschev added the bug Something isn't working label Nov 1, 2022
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pentschev
Copy link
Member Author

Thanks @msadang .

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3dbc4c9 into rapidsai:branch-22.12 Nov 2, 2022
@pentschev pentschev deleted the install-dask-nightly-last branch February 28, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants