Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less restrictive pins in release version #911

Closed
ntabris opened this issue May 18, 2022 · 5 comments
Closed

Less restrictive pins in release version #911

ntabris opened this issue May 18, 2022 · 5 comments

Comments

@ntabris
Copy link
Contributor

ntabris commented May 18, 2022

The current release of dask-cuda is pinned to dask/distributed 2022.03.0.

There's a merged PR to unpin these "for development" (#892) which implies that they're going to be pinned again for release.

Is there a reason for the exact pinning? The PR that pinned these (#878) says it's to be in line with cuDF and the PR that pinned for cuDF gave no reason.

@pentschev
Copy link
Member

Yes, Dask provides no API guarantees. Dask-CUDA is the backbone of RAPIDS and just allowing Dask-CUDA release package to pick the latest Dask/Distributed is guaranteed to be a source of problem after a few (or even just one) release. Therefore we need to pin to a version that we test and is known to work.

Before every RAPIDS release we decide what Dask/Distributed release is stable and pin that version, which we then unpin when we begin working on the new branch for the upcoming RAPIDS release.

@pentschev
Copy link
Member

We have a discussion about this in #848 as well.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@pentschev
Copy link
Member

Given this isn't something we are likely to change due to the reasons in #911 (comment) and since there has been no further discussions, I'm closing this issue. Please feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants