Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal example of dask-cuda command line cluster setup #554

Closed
beckernick opened this issue Mar 22, 2021 · 8 comments
Closed

Add minimal example of dask-cuda command line cluster setup #554

beckernick opened this issue Mar 22, 2021 · 8 comments
Labels
question Further information is requested

Comments

@beckernick
Copy link
Member

In the docs, we have a clear example of setting up a LocalCUDACluster. We also list several additional arguments to the "Command Line Tool", which corresponds to the Dask CLI. However, it's not obvious from the dask-cuda documentation what needs to change relative to standard usage of the Dask CLI. We have an example of using dask-cuda-worker in the UCX integration setup, but it's quite possible a user wouldn't look at the UCX integration if they aren't already planning to use UCX.

It would be valuable if we included a minimal example of setting up a multi-node cluster (or equivalent single-node setup) with dask-cuda-worker from the command line, like in the Dask docs. This could live in either dask-cuda or dask. This documentation would be a valuable asset to share with users interested in testing multi-node or from the command line.

@pentschev
Copy link
Member

Just recently @charlesbluca added some code to try and address specifically that, which now lives in https://github.com/rapidsai/dask-cuda/tree/branch-0.19/examples/ucx . Does that cover your question, if not, what else could we do to improve it?

@charlesbluca
Copy link
Member

Maybe it would be better to duplicate some of the general usage info in the UCX section in the Worker section, so that it's more visible? We can always slim down the UCX section later on if we find that parts of it are redundant.

I'm also happy to expand upon the standalone utilities - if we made the use of UCX an option, then they could function as a minimal example of a standard multi/single-node set up.

@pentschev pentschev added the question Further information is requested label Apr 5, 2021
@beckernick
Copy link
Member Author

@charlesbluca I think that approach would be a great idea

@charlesbluca
Copy link
Member

Currently drafting some changes to address the docs aspect of this in #561 - in general, I am leaning towards putting basic usage examples in the first few pages, and moving more advanced configuration to standalone examples in the docs.

rapids-bot bot pushed a commit that referenced this issue Apr 12, 2021
Addresses  #554; I tried to tidy up the installation/specializations/quickstart pages so that some of the more technical stuff could go into some published examples, and probably a new page discussing configuration of LocalCUDACluster / `dask-cuda-worker`.

Also added `sphinx-click` to the dependencies so we can more easily document any changes to `dask-cuda-worker` (#560) - I would also like to get the docstrings for the CLI, LocalCUDACluster, and `initiailize()` up to date and more concise if possible.

Authors:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #561
@github-actions
Copy link

github-actions bot commented May 6, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jakirkham
Copy link
Member

Is this resolved with PR ( #561 ) or was there more work needed here?

@charlesbluca
Copy link
Member

I think that's sufficient - we could always potentially add an example script like those made for UCX.

@beckernick did you get a chance to check out the changes to the docs?

@pentschev
Copy link
Member

I guess this is mostly addressed and since this has been inactive for so long I'm gonna close it for now, but please reopen/file a new issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants