Skip to content

Commit

Permalink
Fix recorded time in merge benchmark (#1028)
Browse files Browse the repository at this point in the history
With the merge of #994 I accidentally changed the recorded time in the merge benchmark for the explicit-comms case. Since explicit-comms is eager, we must time the entire operation, not just `wait(result.persist())`.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)

URL: #1028
  • Loading branch information
wence- authored Oct 31, 2022
1 parent 40bbfed commit 3e5a19b
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions dask_cuda/benchmarks/local_cudf_merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,13 @@ def merge(args, ddf1, ddf2):
if args.set_index:
ddf_join = ddf_join.set_index("key")
if args.backend == "dask-noop":
t1 = perf_counter()
ddf_join = as_noop(ddf_join)
t1 = perf_counter()
noopify_duration = perf_counter() - t1
else:
noopify_duration = 0
wait(ddf_join.persist())
return perf_counter() - t1
return noopify_duration


def bench_once(client, args, write_profile=None):
Expand Down Expand Up @@ -184,7 +187,9 @@ def bench_once(client, args, write_profile=None):

with ctx1:
with ctx2:
duration = merge(args, ddf_base, ddf_other)
t1 = perf_counter()
noopify_duration = merge(args, ddf_base, ddf_other)
duration = perf_counter() - t1 - noopify_duration

return (data_processed, duration)

Expand Down

0 comments on commit 3e5a19b

Please sign in to comment.