Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs version specifier #385

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

ajschmidt8
Copy link
Member

The current nodejs version specifier is outdated and is causing issues related to #384. This PR updates the specifier to uncap the maximum version and set a new minimum.

@ajschmidt8 ajschmidt8 requested a review from a team as a code owner July 29, 2022 13:55
@ajschmidt8
Copy link
Member Author

related to rapidsai/integration#509

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 29, 2022
@ajschmidt8 ajschmidt8 marked this pull request as draft July 29, 2022 13:55
@ajschmidt8
Copy link
Member Author

Converted PR to draft to ensure it doesn't get accidentally merged before e7f2a3c is reverted.

@ajschmidt8
Copy link
Member Author

ajschmidt8 commented Jul 29, 2022

e7f2a3c has passed CI, which means that once rapidsai/integration#509 is merged and its changes propagated, we should be all set here. I will revert e7f2a3c now.

@github-actions github-actions bot removed the gpuCI label Jul 29, 2022
@ajschmidt8 ajschmidt8 marked this pull request as ready for review July 29, 2022 14:29
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit de90659 into rapidsai:branch-22.08 Jul 29, 2022
@ajschmidt8 ajschmidt8 deleted the update-node branch July 29, 2022 15:29
@jakirkham
Copy link
Member

Thanks AJ! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants