-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainers to use cuda12.2 #72
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-24.06
from
benfred:devcontainers_cuda12_2
Apr 9, 2024
Merged
Update devcontainers to use cuda12.2 #72
rapids-bot
merged 3 commits into
rapidsai:branch-24.06
from
benfred:devcontainers_cuda12_2
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Apr 8, 2024
I believe for rapidsai/devcontainers#261 to pass, we need to also apply the following patch to the cuvs python CMake: diff --git a/python/cuvs/CMakeLists.txt b/python/cuvs/CMakeLists.txt
index 36a6204..b2a6579 100644
--- a/python/cuvs/CMakeLists.txt
+++ b/python/cuvs/CMakeLists.txt
@@ -53,7 +53,7 @@ rapids_cpm_init()
# If the user requested it we attempt to find CUVS.
if(FIND_CUVS_CPP)
- find_package(cuvs "${RAPIDS_VERSION}" REQUIRED)
+ find_package(cuvs "${RAPIDS_VERSION}" REQUIRED COMPONENTS c_api)
include(../../cpp/cmake/thirdparty/get_dlpack.cmake)
else()
set(cuvs_FOUND OFF)
diff --git a/python/cuvs/cuvs/common/CMakeLists.txt b/python/cuvs/cuvs/common/CMakeLists.txt
index b477fdb..3de3805 100644
--- a/python/cuvs/cuvs/common/CMakeLists.txt
+++ b/python/cuvs/cuvs/common/CMakeLists.txt
@@ -14,7 +14,7 @@
# Set the list of Cython files to build
set(cython_sources cydlpack.pyx exceptions.pyx)
-set(linked_libraries cuvs::cuvs cuvs_c)
+set(linked_libraries cuvs::cuvs cuvs::c_api)
# Build all of the Cython targets
rapids_cython_create_modules(
diff --git a/python/cuvs/cuvs/neighbors/cagra/CMakeLists.txt b/python/cuvs/cuvs/neighbors/cagra/CMakeLists.txt
index 377cfe7..87e6597 100644
--- a/python/cuvs/cuvs/neighbors/cagra/CMakeLists.txt
+++ b/python/cuvs/cuvs/neighbors/cagra/CMakeLists.txt
@@ -14,7 +14,7 @@
# Set the list of Cython files to build
set(cython_sources cagra.pyx)
-set(linked_libraries cuvs::cuvs cuvs_c)
+set(linked_libraries cuvs::cuvs cuvs::c_api)
# Build all of the Cython targets
rapids_cython_create_modules( |
cjnolet
approved these changes
Apr 9, 2024
AyodeAwe
approved these changes
Apr 9, 2024
/merge |
AyodeAwe
added a commit
to AyodeAwe/cuvs
that referenced
this pull request
Apr 10, 2024
Closed
difyrrwrzd
added a commit
to difyrrwrzd/cuvs
that referenced
this pull request
Aug 10, 2024
Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai/cuvs#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.