Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include errors, header, and unsafe locks in iface.hpp #467

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Fix include errors, header, and unsafe locks in iface.hpp #467

merged 5 commits into from
Nov 14, 2024

Conversation

achirkin
Copy link
Contributor

Fix a few issues with the internal header neighbors/iface/iface.hpp leading to compile time errors and dangerous runtime behavior:

  • Add missing includes
  • Use std::lock_guard to avoid a deadlock on exception
  • Add NVIDIA header
  • Avoid an extra stream sync during search.

@achirkin achirkin added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 14, 2024
@achirkin achirkin requested a review from a team as a code owner November 14, 2024 08:39
@achirkin achirkin requested a review from viclafargue November 14, 2024 08:39
@github-actions github-actions bot added the cpp label Nov 14, 2024
viclafargue
viclafargue approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for looking into this @achirkin!

@jameslamb jameslamb mentioned this pull request Nov 14, 2024
Merged
@benfred
Copy link
Member

benfred commented Nov 14, 2024

/merge

@rapids-bot rapids-bot bot merged commit bb9c669 into rapidsai:branch-24.12 Nov 14, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viclafargue viclafargue viclafargue approved these changes

@cjnolet cjnolet cjnolet approved these changes

@benfred benfred benfred approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achirkin @benfred @cjnolet @viclafargue