Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce wheel size limits, README formatting in CI #464

Merged
merged 2 commits into from
Nov 14, 2024
Merged

enforce wheel size limits, README formatting in CI #464

merged 2 commits into from
Nov 14, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#110

Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change DO NOT MERGE labels Nov 13, 2024
@jameslamb jameslamb mentioned this pull request Nov 13, 2024
Closed
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] enforce wheel size limits, README formatting in CI enforce wheel size limits, README formatting in CI Nov 13, 2024
@jameslamb jameslamb requested a review from bdice November 13, 2024 17:05
@jameslamb jameslamb marked this pull request as ready for review November 13, 2024 17:05
@jameslamb jameslamb requested review from a team as code owners November 13, 2024 17:05
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit fdb1180 into rapidsai:branch-24.12 Nov 14, 2024
55 checks passed
@jameslamb jameslamb deleted the wheel-validation branch November 14, 2024 03:32
@jameslamb jameslamb mentioned this pull request Nov 14, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Nov 15, 2024
@jameslamb
use different wheel-size thresholds based on CUDA version (#469)
7b87911 
`cuvs-cu11` wheels are significantly larger than `cuvs-cu12` wheels, because (among other reasons) they are not able to dynamically link to CUDA math library wheels.

In #464, I proposed a size limit for CI checks of "max CUDA 11 wheel size + a buffer".

This PR proposes using different thresholds based on CUDA major version, following these discussions:

* rapidsai/cugraph#4754 (comment)
* rapidsai/cuml#6136 (comment)

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)

URL: #469
@jameslamb jameslamb mentioned this pull request Dec 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice