-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python API for CAGRA+HNSW #246
Conversation
@divyegala I observed that same pip devcontainer build failure on an unrelated PR: #247 (comment) So I suspect it's unrelated to your changes here. |
@jameslamb I suspect it's related to this PR rapidsai/raft#2346 What I cannot figure out is why conda-cpp builds pass (new conda packages released?) but wheel builds fail. cuVS wheel builds pick up libraft wheel builds? |
Maybe conda packages weren't out yet when the builds failed? Wheel builds will pull the source of raft to rebuild the static lib (unless you changed something in how cuvs wheels specifically are built, but I don't see any indication of that in the CMake). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Mostly a couple small documentation-related things to polish this off and then I think it's ready to merge.
cpp/include/cuvs/neighbors/cagra.h
Outdated
@@ -416,6 +428,32 @@ cuvsError_t cuvsCagraSerialize(cuvsResources_t res, | |||
cuvsCagraIndex_t index, | |||
bool include_dataset); | |||
|
|||
/** | |||
* Save the CAGRA index to file in hnswlib format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note here that this must be loaded by the (patched) hnswlib wrappers inside cuVS and it can't just be loaded with hnswlib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is shaping up great. Mostly minor things, but important nonetheless.
/merge |
No description provided.