Fix pinning to a different RAFT tag #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to pin the version of a raft to a custom fork wasn't working, and it was still using the version installed by conda. Fix by mirroing the `CUML_RAFT_CLONE_ON_PIN` logic found in the cuml cmake files.
benfred
added
improvement
divyegala
reviewed
Jul 19, 2024
python/cuvs/CMakeLists.txt
Outdated
| @@ -37,6 +37,7 @@ project( | |||
| option(FIND_CUVS_CPP "Search for existing CUVS C++ installations before defaulting to local files" | |||
| OFF | |||
| ) | |||
| set(CUVS_RAFT_CLONE_ON_PIN OFF) | |||
There was a problem hiding this comment.
Why does this need to be set off?
There was a problem hiding this comment.
I copied the logic here from cuml https://github.com/rapidsai/cuml/blob/99b20f67c6dea4aba80da5787f64557dba30a1f8/python/cuml/CMakeLists.txt#L41 - but now I'm wondering if this might have been accidentally applied in cuml in rapidsai/cuml#4990 , and not meant to be included there permanently.
Removed in latest commit
There was a problem hiding this comment.
Thanks for tracking that down, definitely looks to be accidental.
divyegala
approved these changes
Jul 19, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to pin the version of a raft to a custom fork wasn't working, and it was still using the version installed by conda. Fix by mirroing the
CUML_RAFT_CLONE_ON_PINlogic found in the cuml cmake files.