Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent CAGRA kernel #215
Persistent CAGRA kernel #215
Changes from 5 commits
8b76ff7
80ba46e
73ca412
12e228a
14fc20c
554fec7
eeb50fc
0408707
4c8d432
691a9b3
6883517
8007f5a
628cb62
a5ee7bc
4e4317d
acd9f5e
4d6f2d4
8c31553
8426ce9
d94ad77
c63da90
d2ca9ad
103cb24
1611912
8b65f95
04c2745
b757aa9
53a9ba5
69a8740
b7f5106
05100ce
1c23549
f9ee7c7
5bc2982
ee35f74
7195a2b
b138a07
0bfb6be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? Isn't large batch kernel executing longer simply because of the batch size? Or do you mean time per query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We measure the total wall time of processing the given number of queries here, either in one batch or one query at a time in an async loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clarify: "While the persistent kernel provides minimal latency for each small batch
search
call, the wall time to process all the queries in async mode (1 query per job) is up to 2x slower than ..."