Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a CAGRA graph opt bug #192

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Jun 17, 2024

There is a bug in the current CAGRA graph rank-based neighbor reordering process. A low recall or illegal memory access can occur if there are many detourable nodes from a node to its neighbors, e.g. there is a small subgraph in the initial kNN graph. This PR fixes this.

@enp1s0 enp1s0 requested a review from a team as a code owner June 17, 2024 10:32
@github-actions github-actions bot added the cpp label Jun 17, 2024
@enp1s0 enp1s0 added bug Something isn't working non-breaking Introduces a non-breaking change and removed cpp labels Jun 17, 2024
@enp1s0 enp1s0 self-assigned this Jun 17, 2024
@github-actions github-actions bot added the cpp label Jun 17, 2024
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enp1s0 for the fix. The PR looks good to me.

@tfeher
Copy link
Contributor

tfeher commented Jun 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit 581c9cc into rapidsai:branch-24.08 Jun 18, 2024
54 checks passed
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Jun 19, 2024
backport of rapidsai/cuvs#192

There is a bug in the current CAGRA graph rank-based neighbor reordering process. A low recall or illegal memory access can occur if there are many detourable nodes from a node to its neighbors, e.g. there is a small subgraph in the initial kNN graph. This PR fixes this.

Authors:
  - tsuki (https://github.com/enp1s0)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)

URL: #2365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants