Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] ANN bench improvements #160

Open
3 of 9 tasks
tfeher opened this issue May 28, 2024 · 1 comment
Open
3 of 9 tasks

[FEA] ANN bench improvements #160

tfeher opened this issue May 28, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@tfeher
Copy link
Contributor

tfeher commented May 28, 2024 •
edited by achirkin
Loading

During porting the ANN benchmarks from RAFT (#130), a list of potential improvements was created:

  • clang-tidy: cleanup naming conventions
  • cleanup/unify logging (including CPU-only builds)
  • fix/unify create_algo + create_search_param syntax
  • actualize cuda_stub.hpp for cpu-only builds
  • make sure there's no direct cuda dependencies in benchmark.hpp
  • add the memory interconnect info to benchmark context
  • add command line string which used for running the benchmarking to the benchmark context
  • add more information about CPU cores and RAM to the benchmark context
  • etc...
@tfeher tfeher added the feature request New feature or request label May 28, 2024
@tfeher tfeher mentioned this issue May 28, 2024
Merged
10 tasks
@tfeher
Copy link
Contributor Author

tfeher commented Jun 17, 2024

Suggestions for improved naming

@achirkin achirkin mentioned this issue Jul 24, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 29, 2024
@achirkin
Add more info to ANN_BENCH context (#248)
98c07f9 
Add extra information to benchmark context for better reproducibility and performance analysis:

  1. Full command line used to call the executable (so you can copy-paste and run again).
  2. More CUDA device information: whether HMM, AST, or host atomics are available (how GPU can efficiently communicate with CPU).
  3. Host information: min/max frequences, used virtual processors and cores, available physical memory and swap (does the benchmark segfault due to not enough host memory? is SMT enabled? etc).

Addresses parts of #160

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)

URL: #248
divyegala pushed a commit to divyegala/cuvs that referenced this issue Jul 31, 2024
@achirkin @divyegala
Add more info to ANN_BENCH context (rapidsai#248)
0fa0447 
Add extra information to benchmark context for better reproducibility and performance analysis:

  1. Full command line used to call the executable (so you can copy-paste and run again).
  2. More CUDA device information: whether HMM, AST, or host atomics are available (how GPU can efficiently communicate with CPU).
  3. Host information: min/max frequences, used virtual processors and cores, available physical memory and swap (does the benchmark segfault due to not enough host memory? is SMT enabled? etc).

Addresses parts of rapidsai#160

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)

URL: rapidsai#248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tfeher