Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Flakey rust unittest brute_force::tests::test_l2 #127

Open
benfred opened this issue May 16, 2024 · 0 comments
Open

[BUG] Flakey rust unittest brute_force::tests::test_l2 #127

benfred opened this issue May 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@benfred
Copy link
Member

benfred commented May 16, 2024

The brute_force::tests::test_l2 unittest sometimes fails randomly with an error like

thread 'brute_force::tests::test_l2' panicked at cuvs/src/brute_force.rs:164:9:
assertion `left == right` failed
  left: 13
 right: 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    brute_force::tests::test_l2

Re-running the tests usually resolves, but we should find out why this test isn't reliable and fix.
@benfred benfred added the bug Something isn't working label May 16, 2024
benfred added a commit to benfred/cuvs that referenced this issue Jul 17, 2024
@benfred
Mark the rust brute force unittest as flaky
654cd33 
The rust `brute_force::tests::test_l2` test can sometimes randomly
fail (rapidsai#127).

While we should figure out whats causing the test failure, but in
the meantime - this PR marks the test as flaky using the `mark_flaky_tests`
crate, which will retry the test 3 times and pass it if any
of those runs work.
@benfred benfred mentioned this issue Jul 17, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 17, 2024
@benfred
Mark the rust brute force unittest as flaky (#226)
43ed8cc 
The rust `brute_force::tests::test_l2` test can sometimes randomly fail (#127).

We should figure out whats causing the test failure, but in the meantime - this PR marks the test as flaky using the `mark_flaky_tests` crate, which will retry the test 3 times and pass it if any of those runs succeed.

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benfred