This repository has been archived by the owner on Feb 27, 2021. It is now read-only.
Split build and host
#155
Merged
Split build and host
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In conda-build 3, the new `host` environment was created and split from `build` requirements. If both are listed, conda-build creates two separate environments each with their own requirements. The build environment is only used to provide command line tools (not libraries) for the build and the host environment is for all dependencies that are linked to the package. Here we split the build and host environments and move `cmake` into the `build` requirements. This should ensure the package is not linked to `openssl` at run time.
|
Added a more detailed explanation of what was going on above. Hopefully this helps. |
kkraus14
approved these changes
Mar 15, 2019
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
In conda-build 3, the new
hostenvironment was created and split frombuildrequirements. If both are listed, conda-build creates two separate environments each with their own requirements. The build environment is only used to provide command line tools (not libraries) for the build and the host environment is for all dependencies that are linked to the package.Here we split the build and host environments and move
cmakeinto thebuildrequirements. Ascmakedepends oncurl, which depends onopenssl, it wound up in the environment. Asopensslusesrun_exports, this amounts to adding anopensslruntime dependency tonvstrings. However this is not need ascmakeis only a build dependency. So we can move it tobuildand leave everything else inhost, which should fix this issue.cc @kkraus14