Add Header-Only `point_polygon_distance`, add non-owning polygon objects #976

isVoid · 2023-03-07T19:14:00Z

Description

Adds multipolygon_range, multipolygon_ref, polygon_ref as non-owning objects for geoarrow compliant polygon types.
Adds pairwise_point_polygon_distance to compute the shortest distances between two columns of multipoints and multipolygons.
Refactors is_point_in_polygon with geometry object input. Dependent on Consistently validate polygon inputs for GeoArrow offset format #973 since geometry objects requires geoarrow input.

closes #703

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

…into feature/polygon_distances

harrism · 2023-03-07T21:04:34Z

This PR also adds pairwise_point_polygon_distance to compute the shortest distances between two columns of multipoints and multilinestrings.

Do you mean multipolygons not multilinestrings?

isVoid · 2023-03-07T21:22:51Z

This PR also adds pairwise_point_polygon_distance to compute the shortest distances between two columns of multipoints and multilinestrings.

Do you mean multipolygons not multilinestrings?

Yes. Should be multipolygons.

…into feature/polygon_distances

cpp/include/cuspatial/experimental/detail/ranges/multipolygon_range.cuh

cpp/include/cuspatial/experimental/geometry_collection/multipolygon_ref.cuh

thomcom · 2023-03-13T14:45:37Z

cpp/include/cuspatial/experimental/point_polygon_distance.cuh

+ * @param multipoints Range of multipoints, one per computed distance pair.
+ * @param multipolygons Range of multilinestrings, one per computed distance pair.
+ * @return Output Iterator past the last distance computed
+ *
+ * [LinkLRAI]: https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator
+ * "LegacyRandomAccessIterator"
+ */
+template <class MultiPointRange, class MultiPolygonRange, class OutputIt>
+OutputIt pairwise_point_polygon_distance(MultiPointRange multipoints,
+                                         MultiPolygonRange multipoiygons,
+                                         OutputIt distances_first,
+                                         rmm::cuda_stream_view stream = rmm::cuda_stream_default);


Params do not match the docs. Returning an OutputIt and also taking one as undocumented argument seems fishy.

It's standard for most of our algorithms, just like STL. Returns an iterator to one past the last computed results, as the @return doc says.

I think the doc for @tparam OutputIt needs more detail to say that this must contain a floating point type.

must contain a floating point type.

More precisely, "must be convertible from floating point type", since user can use output transform iterator to convert the result and transform into other types.

cpp/include/cuspatial_test/vector_factories.cuh

cpp/tests/experimental/spatial/point_polygon_distance_test.cu

harrism

Great work. I love the refs and ranges. They make the library much more maintainable and the code more readable.

cpp/include/cuspatial/detail/utility/floating_point.cuh

cpp/include/cuspatial/detail/utility/offset_to_keys.cuh

cpp/include/cuspatial/experimental/point_polygon_distance.cuh

cpp/include/cuspatial/experimental/ranges/multipoint_range.cuh

cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh

cpp/include/cuspatial_test/vector_factories.cuh

…into feature/polygon_distances

cpp/include/cuspatial/detail/utility/upper_bound_index.cuh

This reverts commit 4865922.

isVoid · 2023-03-17T17:56:28Z

/merge

This PR closes #756 , add `pairwise_point_polygon_distance` for python. Depend on #984 #976 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) URL: #988

* Implement `geom_equals` and binary predicates that depend only on it. (#926) This PR implements binary predicates that depend only on equality, which is implemented here using columnar comparison in python. I'm playing with benchmarks of this feature now. On only Point geometries, we begin to outperform geopandas at 50k points, with 60x performance at 10m points. Authors: - H. Thomson Comer (https://github.com/thomcom) Approvers: - Michael Wang (https://github.com/isVoid) URL: #926 * Add python API `pairwise_point_polygon_distance` (#988) This PR closes #756 , add `pairwise_point_polygon_distance` for python. Depend on #984 #976 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) URL: #988 * Add `dependency-file-generator` as `pre-commit` hook (#1008) Similarly to these [cudf](rapidsai/cudf#12819) and [cuml](rapidsai/cuml#5246) PRs, this PR adds an entry to `.pre-commit-config.yaml` to run the [dependency-file-generator](https://github.com/rapidsai/dependency-file-generator). It also adds an argument to the `rapidsai/shared-action-workflows/.github/workflows/checks.yaml` shared workflow to disable the `dependency-file-generator` from running in that shared workflow. This avoids having the `dependency-file-generator` run in two places since pre-commit is run in CI [here](https://github.com/rapidsai/cuspatial/blob/branch-23.04/ci/check_style.sh#L23). Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #1008 * Add ZipCode Counting Notebook (#919) This PR adds a notebook that demonstrate the use of quadtree PiP with a custom `QuadTree` structure and joins dataframe. We can use this PR to discuss the possibility of adding the custom structure to the codebase. This also updates the dependency list to include notebook environment in "all" targeted conda envs. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Mark Harris (https://github.com/harrism) - AJ Schmidt (https://github.com/ajschmidt8) URL: #919 * Header-only `quadtree_point_in_polygon` (#979) Closes #985 Also contains cleanup of docs for other spatial join functions, correct ordering of stream and MR parameters, and adds missing C++17 property from tests cmake configuration. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Wang (https://github.com/isVoid) - Paul Taylor (https://github.com/trxcllnt) URL: #979 * Reduce gtest times (#1018) Fixes #1017. Reduces C++ gtest total time (on my PC) from 47.9 seconds to 20.08 seconds. Several tests were running large datasets and combinations of size parameters that would be better to run as benchmarks rather than gtests. Reducing these by a factor of 10-100 saves a lot of development time and still exercises the code. In the case of `HausdorffTest/1.10000Spaces10Points (4850 ms)`, reducing it to 1000 spaces, 10 points reduced the time by nearly 100x, likely because it's $O(N^2)$. I modified any test that used close to 1s or more total time, since most column-API tests use under that, and most header-only tests use under 0.2s. | Test | Time Before (s) | Time After (s) | Speedup | |---|---|---|---| | DERIVE_TRAJECTORIES_TEST_EXP | 14.49 | 0.27 | 53.7x | | HAUSDORFF_TEST_EXP | 9.21 | 0.26 | 35.4x | | UTILITY_TEST | 1.86 | 0.30 | 6.2x | | POINT_BOUNDING_BOXES_TEST_EXP | 1.35 | 0.15 | 9x | | TRAJECTORY_DISTANCES_AND_SPEEDS_TEST_EXP | 0.80 | 0.13 | 6.2x | | TOTAL | 47.9 | 20.08 | 2.4x | Before: ``` (rapids) coder ➜ ~/cuspatial/cpp/build/release $ ninja test [0/1] Running tests... Test project /home/coder/cuspatial/cpp/build/release Start 1: SINUSOIDAL_PROJECTION_TEST 1/45 Test #1: SINUSOIDAL_PROJECTION_TEST ................. Passed 0.81 sec Start 2: HAVERSINE_TEST 2/45 Test #2: HAVERSINE_TEST ............................. Passed 0.77 sec Start 3: HAUSDORFF_TEST 3/45 Test #3: HAUSDORFF_TEST ............................. Passed 0.75 sec Start 4: JOIN_POINT_TO_LINESTRING_SMALL_TEST 4/45 Test #4: JOIN_POINT_TO_LINESTRING_SMALL_TEST ........ Passed 0.73 sec Start 5: JOIN_POINT_IN_POLYGON_TEST 5/45 Test #5: JOIN_POINT_IN_POLYGON_TEST ................. Passed 0.79 sec Start 6: POINT_IN_POLYGON_TEST 6/45 Test #6: POINT_IN_POLYGON_TEST ...................... Passed 0.80 sec Start 7: PAIRWISE_POINT_IN_POLYGON_TEST 7/45 Test #7: PAIRWISE_POINT_IN_POLYGON_TEST ............. Passed 0.76 sec Start 8: POINT_QUADTREE_TEST 8/45 Test #8: POINT_QUADTREE_TEST ........................ Passed 0.76 sec Start 9: LINESTRING_BOUNDING_BOXES_TEST 9/45 Test #9: LINESTRING_BOUNDING_BOXES_TEST ............. Passed 0.76 sec Start 10: POLYGON_BOUNDING_BOXES_TEST 10/45 Test #10: POLYGON_BOUNDING_BOXES_TEST ................ Passed 0.80 sec Start 11: POINT_DISTANCE_TEST 11/45 Test #11: POINT_DISTANCE_TEST ........................ Passed 0.79 sec Start 12: POINT_LINESTRING_DISTANCE_TEST 12/45 Test #12: POINT_LINESTRING_DISTANCE_TEST ............. Passed 0.78 sec Start 13: LINESTRING_DISTANCE_TEST 13/45 Test #13: LINESTRING_DISTANCE_TEST ................... Passed 0.78 sec Start 14: POINT_POLYGON_DISTANCE_TEST 14/45 Test #14: POINT_POLYGON_DISTANCE_TEST ................ Passed 0.76 sec Start 15: LINESTRING_INTERSECTION_TEST 15/45 Test #15: LINESTRING_INTERSECTION_TEST ............... Passed 0.83 sec Start 16: POINT_LINESTRING_NEAREST_POINT_TEST 16/45 Test #16: POINT_LINESTRING_NEAREST_POINT_TEST ........ Passed 0.77 sec Start 17: QUADTREE_POLYGON_FILTERING_TEST 17/45 Test #17: QUADTREE_POLYGON_FILTERING_TEST ............ Passed 0.79 sec Start 18: QUADTREE_LINESTRING_FILTERING_TEST 18/45 Test #18: QUADTREE_LINESTRING_FILTERING_TEST ......... Passed 0.76 sec Start 19: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST 19/45 Test #19: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST ....... Passed 0.79 sec Start 20: DERIVE_TRAJECTORIES_TEST 20/45 Test #20: DERIVE_TRAJECTORIES_TEST ................... Passed 0.76 sec Start 21: TRAJECTORY_BOUNDING_BOXES_TEST 21/45 Test #21: TRAJECTORY_BOUNDING_BOXES_TEST ............. Passed 0.75 sec Start 22: SPATIAL_WINDOW_POINT_TEST 22/45 Test #22: SPATIAL_WINDOW_POINT_TEST .................. Passed 0.75 sec Start 23: UTILITY_TEST 23/45 Test #23: UTILITY_TEST ............................... Passed 1.86 sec Start 24: HAVERSINE_TEST_EXP 24/45 Test #24: HAVERSINE_TEST_EXP ......................... Passed 0.14 sec Start 25: POINT_DISTANCE_TEST_EXP 25/45 Test #25: POINT_DISTANCE_TEST_EXP .................... Passed 0.11 sec Start 26: POINT_LINESTRING_DISTANCE_TEST_EXP 26/45 Test #26: POINT_LINESTRING_DISTANCE_TEST_EXP ......... Passed 0.11 sec Start 27: POINT_POLYGON_DISTANCE_TEST_EXP 27/45 Test #27: POINT_POLYGON_DISTANCE_TEST_EXP ............ Passed 0.13 sec Start 28: HAUSDORFF_TEST_EXP 28/45 Test #28: HAUSDORFF_TEST_EXP ......................... Passed 9.21 sec Start 29: LINESTRING_DISTANCE_TEST_EXP 29/45 Test #29: LINESTRING_DISTANCE_TEST_EXP ............... Passed 0.17 sec Start 30: LINESTRING_INTERSECTION_TEST_EXP 30/45 Test #30: LINESTRING_INTERSECTION_TEST_EXP ........... Passed 0.19 sec Start 31: POINT_LINESTRING_NEAREST_POINT_TEST_EXP 31/45 Test #31: POINT_LINESTRING_NEAREST_POINT_TEST_EXP .... Passed 0.12 sec Start 32: SINUSOIDAL_PROJECTION_TEST_EXP 32/45 Test #32: SINUSOIDAL_PROJECTION_TEST_EXP ............. Passed 0.12 sec Start 33: POINTS_IN_RANGE_TEST_EXP 33/45 Test #33: POINTS_IN_RANGE_TEST_EXP ................... Passed 0.11 sec Start 34: POINT_IN_POLYGON_TEST_EXP 34/45 Test #34: POINT_IN_POLYGON_TEST_EXP .................. Passed 0.12 sec Start 35: PAIRWISE_POINT_IN_POLYGON_TEST_EXP 35/45 Test #35: PAIRWISE_POINT_IN_POLYGON_TEST_EXP ......... Passed 0.11 sec Start 36: DERIVE_TRAJECTORIES_TEST_EXP 36/45 Test #36: DERIVE_TRAJECTORIES_TEST_EXP ............... Passed 14.49 sec Start 37: POINT_BOUNDING_BOXES_TEST_EXP 37/45 Test #37: POINT_BOUNDING_BOXES_TEST_EXP .............. Passed 1.35 sec Start 38: POLYGON_BOUNDING_BOXES_TEST_EXP 38/45 Test #38: POLYGON_BOUNDING_BOXES_TEST_EXP ............ Passed 0.11 sec Start 39: LINESTRING_BOUNDING_BOXES_TEST_EXP 39/45 Test #39: LINESTRING_BOUNDING_BOXES_TEST_EXP ......... Passed 0.11 sec Start 40: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST_EXP 40/45 Test #40: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST_EXP ... Passed 0.80 sec Start 41: POINT_QUADTREE_TEST_EXP 41/45 Test #41: POINT_QUADTREE_TEST_EXP .................... Passed 0.12 sec Start 42: OPERATOR_TEST_EXP 42/45 Test #42: OPERATOR_TEST_EXP .......................... Passed 0.14 sec Start 43: FIND_TEST_EXP 43/45 Test #43: FIND_TEST_EXP .............................. Passed 0.13 sec Start 44: JOIN_POINT_IN_POLYGON_SMALL_TEST_EXP 44/45 Test #44: JOIN_POINT_IN_POLYGON_SMALL_TEST_EXP ....... Passed 0.11 sec Start 45: JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP 45/45 Test #45: JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP ....... Passed 0.13 sec 100% tests passed, 0 tests failed out of 45 Total Test time (real) = 47.07 sec ``` After: ``` (rapids) coder ➜ ~/cuspatial/cpp/build/release $ ninja test [0/1] Running tests... Test project /home/coder/cuspatial/cpp/build/release Start 1: SINUSOIDAL_PROJECTION_TEST 1/45 Test #1: SINUSOIDAL_PROJECTION_TEST ................. Passed 0.78 sec Start 2: HAVERSINE_TEST 2/45 Test #2: HAVERSINE_TEST ............................. Passed 0.75 sec Start 3: HAUSDORFF_TEST 3/45 Test #3: HAUSDORFF_TEST ............................. Passed 0.74 sec Start 4: JOIN_POINT_TO_LINESTRING_SMALL_TEST 4/45 Test #4: JOIN_POINT_TO_LINESTRING_SMALL_TEST ........ Passed 0.77 sec Start 5: JOIN_POINT_IN_POLYGON_TEST 5/45 Test #5: JOIN_POINT_IN_POLYGON_TEST ................. Passed 0.76 sec Start 6: POINT_IN_POLYGON_TEST 6/45 Test #6: POINT_IN_POLYGON_TEST ...................... Passed 0.78 sec Start 7: PAIRWISE_POINT_IN_POLYGON_TEST 7/45 Test #7: PAIRWISE_POINT_IN_POLYGON_TEST ............. Passed 0.74 sec Start 8: POINT_QUADTREE_TEST 8/45 Test #8: POINT_QUADTREE_TEST ........................ Passed 0.75 sec Start 9: LINESTRING_BOUNDING_BOXES_TEST 9/45 Test #9: LINESTRING_BOUNDING_BOXES_TEST ............. Passed 0.75 sec Start 10: POLYGON_BOUNDING_BOXES_TEST 10/45 Test #10: POLYGON_BOUNDING_BOXES_TEST ................ Passed 0.73 sec Start 11: POINT_DISTANCE_TEST 11/45 Test #11: POINT_DISTANCE_TEST ........................ Passed 0.73 sec Start 12: POINT_LINESTRING_DISTANCE_TEST 12/45 Test #12: POINT_LINESTRING_DISTANCE_TEST ............. Passed 0.74 sec Start 13: LINESTRING_DISTANCE_TEST 13/45 Test #13: LINESTRING_DISTANCE_TEST ................... Passed 0.76 sec Start 14: POINT_POLYGON_DISTANCE_TEST 14/45 Test #14: POINT_POLYGON_DISTANCE_TEST ................ Passed 0.76 sec Start 15: LINESTRING_INTERSECTION_TEST 15/45 Test #15: LINESTRING_INTERSECTION_TEST ............... Passed 0.78 sec Start 16: POINT_LINESTRING_NEAREST_POINT_TEST 16/45 Test #16: POINT_LINESTRING_NEAREST_POINT_TEST ........ Passed 0.77 sec Start 17: QUADTREE_POLYGON_FILTERING_TEST 17/45 Test #17: QUADTREE_POLYGON_FILTERING_TEST ............ Passed 0.75 sec Start 18: QUADTREE_LINESTRING_FILTERING_TEST 18/45 Test #18: QUADTREE_LINESTRING_FILTERING_TEST ......... Passed 0.77 sec Start 19: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST 19/45 Test #19: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST ....... Passed 0.74 sec Start 20: DERIVE_TRAJECTORIES_TEST 20/45 Test #20: DERIVE_TRAJECTORIES_TEST ................... Passed 0.75 sec Start 21: TRAJECTORY_BOUNDING_BOXES_TEST 21/45 Test #21: TRAJECTORY_BOUNDING_BOXES_TEST ............. Passed 0.74 sec Start 22: SPATIAL_WINDOW_POINT_TEST 22/45 Test #22: SPATIAL_WINDOW_POINT_TEST .................. Passed 0.75 sec Start 23: UTILITY_TEST 23/45 Test #23: UTILITY_TEST ............................... Passed 0.30 sec Start 24: HAVERSINE_TEST_EXP 24/45 Test #24: HAVERSINE_TEST_EXP ......................... Passed 0.12 sec Start 25: POINT_DISTANCE_TEST_EXP 25/45 Test #25: POINT_DISTANCE_TEST_EXP .................... Passed 0.12 sec Start 26: POINT_LINESTRING_DISTANCE_TEST_EXP 26/45 Test #26: POINT_LINESTRING_DISTANCE_TEST_EXP ......... Passed 0.12 sec Start 27: POINT_POLYGON_DISTANCE_TEST_EXP 27/45 Test #27: POINT_POLYGON_DISTANCE_TEST_EXP ............ Passed 0.13 sec Start 28: HAUSDORFF_TEST_EXP 28/45 Test #28: HAUSDORFF_TEST_EXP ......................... Passed 0.26 sec Start 29: LINESTRING_DISTANCE_TEST_EXP 29/45 Test #29: LINESTRING_DISTANCE_TEST_EXP ............... Passed 0.14 sec Start 30: LINESTRING_INTERSECTION_TEST_EXP 30/45 Test #30: LINESTRING_INTERSECTION_TEST_EXP ........... Passed 0.19 sec Start 31: POINT_LINESTRING_NEAREST_POINT_TEST_EXP 31/45 Test #31: POINT_LINESTRING_NEAREST_POINT_TEST_EXP .... Passed 0.11 sec Start 32: SINUSOIDAL_PROJECTION_TEST_EXP 32/45 Test #32: SINUSOIDAL_PROJECTION_TEST_EXP ............. Passed 0.11 sec Start 33: POINTS_IN_RANGE_TEST_EXP 33/45 Test #33: POINTS_IN_RANGE_TEST_EXP ................... Passed 0.13 sec Start 34: POINT_IN_POLYGON_TEST_EXP 34/45 Test #34: POINT_IN_POLYGON_TEST_EXP .................. Passed 0.11 sec Start 35: PAIRWISE_POINT_IN_POLYGON_TEST_EXP 35/45 Test #35: PAIRWISE_POINT_IN_POLYGON_TEST_EXP ......... Passed 0.14 sec Start 36: DERIVE_TRAJECTORIES_TEST_EXP 36/45 Test #36: DERIVE_TRAJECTORIES_TEST_EXP ............... Passed 0.27 sec Start 37: POINT_BOUNDING_BOXES_TEST_EXP 37/45 Test #37: POINT_BOUNDING_BOXES_TEST_EXP .............. Passed 0.15 sec Start 38: POLYGON_BOUNDING_BOXES_TEST_EXP 38/45 Test #38: POLYGON_BOUNDING_BOXES_TEST_EXP ............ Passed 0.13 sec Start 39: LINESTRING_BOUNDING_BOXES_TEST_EXP 39/45 Test #39: LINESTRING_BOUNDING_BOXES_TEST_EXP ......... Passed 0.12 sec Start 40: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST_EXP 40/45 Test #40: TRAJECTORY_DISTANCES_AND_SPEEDS_TEST_EXP ... Passed 0.13 sec Start 41: POINT_QUADTREE_TEST_EXP 41/45 Test #41: POINT_QUADTREE_TEST_EXP .................... Passed 0.14 sec Start 42: OPERATOR_TEST_EXP 42/45 Test #42: OPERATOR_TEST_EXP .......................... Passed 0.14 sec Start 43: FIND_TEST_EXP 43/45 Test #43: FIND_TEST_EXP .............................. Passed 0.15 sec Start 44: JOIN_POINT_IN_POLYGON_SMALL_TEST_EXP 44/45 Test #44: JOIN_POINT_IN_POLYGON_SMALL_TEST_EXP ....... Passed 0.12 sec Start 45: JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP 45/45 Test #45: JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP ....... Passed 0.13 sec 100% tests passed, 0 tests failed out of 45 Total Test time (real) = 20.08 sec ``` Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Wang (https://github.com/isVoid) - Paul Taylor (https://github.com/trxcllnt) URL: #1018 * Re-add enabled_check_generated_files:false --------- Co-authored-by: H. Thomson Comer <[email protected]> Co-authored-by: Michael Wang <[email protected]> Co-authored-by: AJ Schmidt <[email protected]>

isVoid added 14 commits February 28, 2023 10:18

initial

965b80a

Merge branch 'branch-23.04' of https://github.com/rapidsai/cuspatial …

38af8e6

…into feature/polygon_distances

add pragma once for floating_point.cuh

02f61fe

add polygon_ref structure

7bd797f

add multipolygon_ref class

0968c15

update multipolygon_range class

a659eab

update multipoint_range class

c274070

update is_point_in_polygon usage with polygon_ref

12ffa53

update multilinestring_range

7490333

add point to polygon kernel

f665287

add segment deduction guide

291f6e6

add owning object type to vector factories

efa6883

add tests

23146ef

add helper files

ead160a

isVoid self-assigned this Mar 7, 2023

github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 7, 2023

isVoid changed the title ~~Add point_polygon_distance, add non-owning polygon objects~~ [skip-ci] Add point_polygon_distance, add non-owning polygon objects Mar 7, 2023

isVoid added 6 commits March 8, 2023 13:15

add more tests

09bd35f

bug fixes

92760d1

cleanups

8acb5dc

fix tests

a2b94fe

optimize single point range input

46a67fe

docs, type checks in range ctor

b725b52

isVoid changed the title ~~[skip-ci] Add point_polygon_distance, add non-owning polygon objects~~ Add Header-Only point_polygon_distance, add non-owning polygon objects Mar 8, 2023

isVoid marked this pull request as ready for review March 8, 2023 23:00

isVoid requested review from a team as code owners March 8, 2023 23:00

isVoid added 4 commits March 8, 2023 17:52

add docs

744f32f

style

bb6c637

Merge branch 'branch-23.04' of https://github.com/rapidsai/cuspatial …

756650b

…into feature/polygon_distances

fix bug in PiP tests

8319e7c

isVoid changed the title ~~[skip-ci] Add Header-Only point_polygon_distance, add non-owning polygon objects~~ Add Header-Only point_polygon_distance, add non-owning polygon objects Mar 10, 2023

isVoid mentioned this pull request Mar 10, 2023

Add python API pairwise_point_polygon_distance #988

Merged

3 tasks

thomcom requested changes Mar 13, 2023

View reviewed changes

harrism requested changes Mar 14, 2023

View reviewed changes

updates with test docs and API docs, address review

86d36d9

isVoid requested a review from thomcom March 14, 2023 17:24

isVoid added 4 commits March 14, 2023 10:48

update offsets_to_keys

7bf8cbf

update floating_point docs

ff48dc7

use any_of

b4420a7

add large (multigrid) tests, address reviews

44e2843

isVoid requested a review from harrism March 14, 2023 20:44

isVoid added 2 commits March 14, 2023 17:31

Merge branch 'branch-23.04' of https://github.com/rapidsai/cuspatial …

57e6196

…into feature/polygon_distances

add upper_bound_index.cuh

49972d4

harrism reviewed Mar 15, 2023

View reviewed changes

cpp/include/cuspatial/detail/utility/upper_bound_index.cuh Outdated Show resolved Hide resolved

isVoid added 2 commits March 14, 2023 22:52

remove upper_bound_index

f000e00

update geometry id factory

57504e6

isVoid requested a review from harrism March 15, 2023 15:40

isVoid and others added 3 commits March 15, 2023 09:21

add get gtest scripts in cmake

4865922

Revert "add get gtest scripts in cmake"

cb627fc

This reverts commit 4865922.

Merge branch 'branch-23.04' into feature/polygon_distances

dd5d446

harrism approved these changes Mar 16, 2023

View reviewed changes

thomcom approved these changes Mar 17, 2023

View reviewed changes

rapids-bot bot merged commit 6a6aae5 into rapidsai:branch-23.04 Mar 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Header-Only `point_polygon_distance`, add non-owning polygon objects #976

Add Header-Only `point_polygon_distance`, add non-owning polygon objects #976

isVoid commented Mar 7, 2023 •

edited

Loading

harrism commented Mar 7, 2023

isVoid commented Mar 7, 2023

thomcom Mar 13, 2023

harrism Mar 14, 2023

isVoid Mar 14, 2023

harrism left a comment

isVoid commented Mar 17, 2023

Add Header-Only point_polygon_distance, add non-owning polygon objects #976

Add Header-Only point_polygon_distance, add non-owning polygon objects #976

Conversation

isVoid commented Mar 7, 2023 • edited Loading

Description

Checklist

harrism commented Mar 7, 2023

isVoid commented Mar 7, 2023

thomcom Mar 13, 2023

Choose a reason for hiding this comment

harrism Mar 14, 2023

Choose a reason for hiding this comment

isVoid Mar 14, 2023

Choose a reason for hiding this comment

harrism left a comment

Choose a reason for hiding this comment

isVoid commented Mar 17, 2023

Add Header-Only `point_polygon_distance`, add non-owning polygon objects #976

Add Header-Only `point_polygon_distance`, add non-owning polygon objects #976

isVoid commented Mar 7, 2023 •

edited

Loading