Add print_env.sh to improve bug reporting #874
Conversation
Copied from cudf/print_env.sh
jarmak-nv
added
improvement
Codecov ReportBase: 92.55% // Head: 92.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #874 +/- ##
=============================================
Coverage 92.55% 92.55%
=============================================
Files 24 24
Lines 1008 1008
=============================================
Hits 933 933
Misses 75 75 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Welcome back, @jarmak-nv!
Left a quick question on this PR.
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | ||
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | ||
| + print_env.sh output |
There was a problem hiding this comment.
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | |
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | |
| + print_env.sh output | |
| Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | |
| If method of install is Docker, provide `docker pull` & `docker run` commands used | |
| print_env.sh output |
Are these + characters intended?
There was a problem hiding this comment.
Thank you!
Yeah they were intended just as a bullet between the lines because you can't actually do markdown in the placeholder text to make a real bulleted list.
Not married to them though!
There was a problem hiding this comment.
No problem. just checking! Didn't know if it was a copy/paste error.
There was a problem hiding this comment.
I think the bullets are useful. However print_env.sh output is not very instructive. I think it should at least be a link to the .sh file in the repo.
There was a problem hiding this comment.
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | |
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | |
| + print_env.sh output | |
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | |
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | |
| + Run [print_env.sh](https://github.com/rapidsai/cuspatial/blob/main/print_env.sh) and paste in the output. |
There was a problem hiding this comment.
Right now, in the placeholder text the link wouldn't actually work since placeholder text doesn't support markdown.
I've added in a link in the description and referenced it in the placeholder, I think that should be good. Thoughts @harrism?
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | ||
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | ||
| + print_env.sh output |
There was a problem hiding this comment.
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | |
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | |
| + print_env.sh output | |
| + Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] | |
| + If method of install is Docker, provide `docker pull` & `docker run` commands used | |
| + Run [print_env.sh](https://github.com/rapidsai/cuspatial/blob/main/print_env.sh) and paste in the output. |
|
/merge |
Description
Closes #774
print_env.shfile from cudf to get specific environment information during bug reports.Checklist