Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink to users.ipynb for notebooks CI #790

Merged

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Nov 8, 2022

Description

This creates a symlink in notebooks so that @taureandyernv's notebooks CI can test it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@thomcom thomcom self-assigned this Nov 8, 2022
@github-actions github-actions bot added the Python Related to Python code label Nov 8, 2022
@thomcom thomcom added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Python Related to Python code labels Nov 8, 2022
@taureandyernv
Copy link
Contributor

@thomcom , great work as always! Can we rename the "User.ipynb" notebook in cuSpatial to "10 Minutes to CuSpatial" to align better with other intro notebooks naming conventions?

@harrism
Copy link
Member

harrism commented Nov 9, 2022

@thomcom , great work as always! Can we rename the "User.ipynb" notebook in cuSpatial to "10 Minutes to CuSpatial" to align better with other intro notebooks naming conventions?

I think "10 minutes to cuspatial" is a different guide that we haven't written yet. users.ipynb just provides a single simple example for every API in cuSpatial.

@thomcom
Copy link
Contributor Author

thomcom commented Nov 10, 2022

I agree they're not the same thing at this time.

@taureandyernv
Copy link
Contributor

okay, fair enough, then can we rename it from users to something more descriptive of what it is?

@harrism
Copy link
Member

harrism commented Nov 10, 2022

cuspatial_api_usage.ipynb ?

cuspatial_api_examples.ipynb ?

@taureandyernv
Copy link
Contributor

cuspatial_api_intro? cuspatial_api_examples.ipynb is also pretty apt. But I name things like an engineer....

@harrism
Copy link
Member

harrism commented Nov 23, 2022

OK, how do we move this forward? I see two votes for cuspatial_api_examples.ipynb.

@taureandyernv
Copy link
Contributor

Well, looks like the poll are closed! @thomcom, may you rename the file and redo the symlink?

@thomcom
Copy link
Contributor Author

thomcom commented Nov 23, 2022

Will do.

@github-actions github-actions bot added the Python Related to Python code label Nov 23, 2022
@harrism harrism added the doc Documentation label Nov 23, 2022
@thomcom thomcom removed the improvement Improvement / enhancement to an existing function label Nov 28, 2022
@harrism
Copy link
Member

harrism commented Nov 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8745a1a into rapidsai:branch-22.12 Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change Python Related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants