Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ doc links to library_design.md and minor documentation fixes #700

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Sep 28, 2022

Description

This PR fixes some render issue with library_design.md, adds links to c++ documentation (maybe changed after merging 673)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid marked this pull request as ready for review September 28, 2022 17:39
@@ -7,5 +7,4 @@ Functions for identifying and grouping trajectories from point data.

.. autofunction:: cuspatial.derive_trajectories
.. autofunction:: cuspatial.trajectory_distances_and_speeds
.. autofunction:: cuspatial.directed_hausdorff_distance
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate entry also present in spatial.rst

@isVoid isVoid requested a review from harrism September 28, 2022 17:41
@isVoid isVoid added documentation non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels Sep 28, 2022
@isVoid isVoid added this to the Developer Documentation milestone Sep 28, 2022
@isVoid isVoid added the doc Documentation label Sep 28, 2022
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just suggest tightening up the wording of one sentence. Otherwise approve.

docs/source/developer_guide/library_design.md Outdated Show resolved Hide resolved
@thomcom
Copy link
Contributor

thomcom commented Sep 29, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Sep 29, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Sep 29, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5ed8e7d into rapidsai:branch-22.10 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants