Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown Parser to Sphinx #621

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 2, 2022

This PR Adds Myst_parser extension to sphinx docs. This allows developers to write markdown pages for guides and references. In general, this is the more popular choice over reStructuredText. This PR also converts several text heavy documents into markdowns and fixes some build warnings.

Note that rST is still supported and that the api reference folder remains in rST format. In general, markdown favors text heavy documentation such as guides and technical walk-through, while rST is suitable for creating reference trees.

This PR builds up the file organization proposed by #599 and generally follows the layouts of cudf.

@isVoid isVoid requested a review from a team as a code owner August 2, 2022 21:56
@github-actions github-actions bot added the conda Related to conda and conda configuration label Aug 2, 2022
@isVoid isVoid added this to the Developer Documentation milestone Aug 2, 2022
@isVoid isVoid added doc Documentation Python Related to Python code 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 2, 2022
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

@harrism
Copy link
Member

harrism commented Aug 2, 2022

Can you please retarget this PR to 22.10?

@isVoid isVoid changed the base branch from branch-22.08 to branch-22.10 August 3, 2022 00:16
@isVoid
Copy link
Contributor Author

isVoid commented Aug 3, 2022

@gpucibot merge

Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any changes are required to rapids-doc-env because myst-nb pulls in myst-parser.

@rapids-bot rapids-bot bot merged commit d5073cc into rapidsai:branch-22.10 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team conda Related to conda and conda configuration doc Documentation non-breaking Non-breaking change Python Related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants