Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve point_in_polygon documentation regarding poly_ring_offsets #497

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Improve point_in_polygon documentation regarding poly_ring_offsets #497

merged 3 commits into from
Mar 31, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Mar 16, 2022

Partially addresses #492.

Adds notes to the Python and C++ documentation explaining that behavior is undefined if there are rings in poly_ring_offsets that are not referenced by poly_offsets

@harrism harrism requested review from a team as code owners March 16, 2022 04:17
@github-actions github-actions bot added libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Mar 16, 2022
@harrism harrism added doc Documentation non-breaking Non-breaking change labels Mar 16, 2022
@harrism
Copy link
Member Author

harrism commented Mar 16, 2022

Should probably also fix the taxi notebook but I need to get it running locally before I can test any fixes.

@harrism harrism requested a review from isVoid March 29, 2022 02:53
@isVoid
Copy link
Contributor

isVoid commented Mar 30, 2022

Might be out of scope, would it be helpful to add an example of input to help demonstrate the use of the API?

@harrism
Copy link
Member Author

harrism commented Mar 31, 2022

@isVoid Yes. However I'm going to merge this and add your note to the still-open issue. This way at least we get some improvement in the current release.

@harrism harrism mentioned this pull request Mar 31, 2022
Open
@harrism
Copy link
Member Author

harrism commented Mar 31, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7709a43 into rapidsai:branch-22.04 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@cwharris cwharris cwharris approved these changes

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@isVoid isVoid Awaiting requested review from isVoid

Assignees
No one assigned
Labels
doc Documentation libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harrism @isVoid @thomcom @cwharris