Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin gdal to 3.3.x #420

Merged
merged 15 commits into from
Aug 20, 2021
Merged

Pin gdal to 3.3.x #420

merged 15 commits into from
Aug 20, 2021

Conversation

weiji14
Copy link
Contributor

@weiji14 weiji14 commented Jun 15, 2021

Bump gdal from 3.2.x to 3.3.x. Supersedes #347. This is inline with conda-forge's current migration to gdal=3.3.x (see conda-forge/conda-forge-pinning-feedstock#1506 and https://conda-forge.org/status/#gdal33).

Update on rapidsai/integration is at rapidsai/integration#300.

Bump `gdal` from 3.2.x to 3.3.x. Supersedes #347.
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@github-actions github-actions bot added the conda Related to conda and conda configuration label Jun 15, 2021
@github-actions github-actions bot added the gpuCI Related to Continuous Integration / Automation label Jun 15, 2021
@ajschmidt8
Copy link
Member

ok to test

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 18, 2021
@weiji14
Copy link
Contributor Author

weiji14 commented Jun 22, 2021

There are 2 failing tests. Not quite sure what to do with these though 😅

[  FAILED  ] PIPRefineTestLarge/0.TestLarge, where TypeParam = float (1063 ms)
[----------] 1 test from PIPRefineTestLarge/0 (1063 ms total)

[----------] 1 test from PIPRefineTestLarge/1, where TypeParam = double
[ RUN      ] PIPRefineTestLarge/1.TestLarge
../tests/utilities/column_utilities.cu:68: Failure
Expected equality of these values:
  lhs.size()
    Which is: 0
  rhs.size()
    Which is: 885
../tests/utilities/column_utilities.cu:68: Failure
Expected equality of these values:
  lhs.size()
    Which is: 0
  rhs.size()
    Which is: 885
../tests/utilities/column_utilities.cu:68: Failure
Expected equality of these values:
  lhs.size()
    Which is: 0
  rhs.size()
    Which is: 885
[  FAILED  ] PIPRefineTestLarge/1.TestLarge, where TypeParam = double (30 ms)
[----------] 1 test from PIPRefineTestLarge/1 (30 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 2 test suites ran. (1093 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] PIPRefineTestLarge/0.TestLarge, where TypeParam = float
[  FAILED  ] PIPRefineTestLarge/1.TestLarge, where TypeParam = double

 2 FAILED TESTS

@ajschmidt8
Copy link
Member

There are 2 failing tests. Not quite sure what to do with these though

@thomcom, any thoughts here?

@thomcom
Copy link
Contributor

thomcom commented Jul 6, 2021

For some reason I missed this in my github notifications feed, I'll take a look at it this week. Thanks!

@harrism
Copy link
Member

harrism commented Jul 20, 2021

@thomcom any update? Moving to 21.10, please retarget the branch.

@weiji14 weiji14 changed the base branch from branch-21.08 to branch-21.10 July 22, 2021 09:06
@thomcom
Copy link
Contributor

thomcom commented Aug 18, 2021

rerun tests

@thomcom thomcom marked this pull request as ready for review August 18, 2021 21:30
@thomcom thomcom requested a review from a team as a code owner August 18, 2021 21:30
@github-actions github-actions bot added the Python Related to Python code label Aug 19, 2021
Copy link
Contributor Author

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the tests pass? And can we move on with rapidsai/integration#300?

ci/gpu/build.sh Outdated Show resolved Hide resolved
@jjacobelli jjacobelli requested a review from a team as a code owner August 19, 2021 14:37
@github-actions github-actions bot removed the gpuCI Related to Continuous Integration / Automation label Aug 19, 2021
@jjacobelli
Copy link
Contributor

rerun tests

Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errr, didn't realize this was wip.

@weiji14 weiji14 requested a review from a team as a code owner August 19, 2021 20:32
@thomcom
Copy link
Contributor

thomcom commented Aug 19, 2021

rerun tests

1 similar comment
@jjacobelli
Copy link
Contributor

rerun tests

@thomcom
Copy link
Contributor

thomcom commented Aug 19, 2021

@cwharris any chance you can reformat this pr with scripts/run-clang-format.py assuming you already have clang-format 11? Mine is 8.0.1 in conda and I'm not confident of how to get to 11.0.0 quickly.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Aug 20, 2021
@thomcom
Copy link
Contributor

thomcom commented Aug 20, 2021

@dillon-cullinan can I get an approve 420?

@ajschmidt8 ajschmidt8 changed the title [WIP] Pin gdal to 3.3.x Pin gdal to 3.3.x Aug 20, 2021
@thomcom
Copy link
Contributor

thomcom commented Aug 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2c4b9a into rapidsai:branch-21.10 Aug 20, 2021
@weiji14 weiji14 deleted the gdal-3.3 branch August 20, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants