Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix branch-0.15 conda dev environment dependencies #267

Merged
merged 4 commits into from
Aug 21, 2020
Merged

[REVIEW] Fix branch-0.15 conda dev environment dependencies #267

merged 4 commits into from
Aug 21, 2020

Conversation

trxcllnt
Copy link
Contributor

  • Update cuDF to 0.15
  • Inherit black, flake8, and isort versions from cudf

@trxcllnt trxcllnt requested a review from a team as a code owner August 19, 2020 19:01
@trxcllnt trxcllnt mentioned this pull request Aug 19, 2020
Closed
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

raydouglass
raydouglass approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to consider updating https://github.com/rapidsai/cuspatial/blob/branch-0.15/ci/release/update-version.sh to automatically update the environment files like cuML does: https://github.com/rapidsai/cuml/blob/branch-0.15/ci/release/update-version.sh#L55

@trxcllnt
Copy link
Contributor Author

Blocked until #268 is merged.

@trxcllnt
Copy link
Contributor Author

rerun tests

@trxcllnt
Copy link
Contributor Author

rerun tests

@trxcllnt
Copy link
Contributor Author

@raydouglass changelog checking script seems to be encountering an error

@kkraus14
Copy link
Contributor

rerun tests

@mike-wendt
Copy link
Contributor

rerun tests - #272 fixed the changelog check

@raydouglass raydouglass merged commit ad0b92b into rapidsai:branch-0.15 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trxcllnt @GPUtester @kkraus14 @mike-wendt @raydouglass