cuproj: remove pin on 'proj' in conda packages #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
jameslamb
changed the title
jameslamb
added
3 - Ready for Review
jakirkham
approved these changes
Aug 30, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
…as>=1.0 (#1453) Contributes to rapidsai/build-planning#40 This PR adds support for Python 3.12. ## Notes for Reviewers This is part of ongoing work to add Python 3.12 support across RAPIDS. It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213. A follow-up PR will revert back to pointing at the `branch-24.10` branch of `shared-workflows` once all RAPIDS repos have added Python 3.12 support. Other changes required to add that support: * pinning `proj` back to 9.3.x, reverting #1449 (#1453 (comment)) * requiring `geopandas >= 1.0` (#1453 (comment)) ### This will fail until all dependencies have been updates to Python 3.12 CI here is expected to fail until all of this project's upstream dependencies support Python 3.12. This can be merged whenever all CI jobs are passing. Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposes removing the
cuprojconda package's pin onproj, so that it can build using the same version thatconda-forgepins to in https://github.com/conda-forge/conda-forge-pinning-feedstock.For context, see:
proj==9.3.0pin was originally added: Pinprojto9.3.0incuproj#1307conda-forgecompletied migrations:9.3.1: Close out migration for proj931 conda-forge/conda-forge-pinning-feedstock#54019.4.: Close out migration for proj_loosen_pin conda-forge/conda-forge-pinning-feedstock#6240Checklist