Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cudf::column constructor args #1151

Merged
merged 5 commits into from
May 26, 2023
Merged

Fix cudf::column constructor args #1151

merged 5 commits into from
May 26, 2023

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented May 23, 2023 •
edited by bdice
Loading

Description

Update cudf::column constructor args to match the changes in rapidsai/cudf#13341.

Also corrects a minor issue in the docs, closes #1154.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 23, 2023
@trxcllnt trxcllnt requested a review from a team as a code owner May 23, 2023 21:47
@trxcllnt trxcllnt requested review from harrism and isVoid May 23, 2023 21:47
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label May 23, 2023
@trxcllnt
Copy link
Contributor Author

Failing test seems like an unrelated cuML bug.

@isVoid
Copy link
Contributor

isVoid commented May 24, 2023 •
edited
Loading

Failing test seems like an unrelated cuML bug.

Tracked by: rapidsai/cuml#5434

@harrism
Copy link
Member

harrism commented May 24, 2023

How do we rerun tests? Is the cuML fix in last night's nightly?

@harrism
Copy link
Member

harrism commented May 24, 2023

How do we rerun tests? Is the cuML fix in last night's nightly?

FIgured this out. Click on failing action, look for rerun icon in top right (circular arrows).
image

@thomcom thomcom mentioned this pull request May 25, 2023
Closed
3 tasks
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@bdice
Copy link
Contributor

bdice commented May 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5162e39 into rapidsai:branch-23.06 May 26, 2023
@bdice
Copy link
Contributor

bdice commented May 26, 2023 •
edited
Loading

I went ahead and merged this since it fixes nightlies, which are needed for 23.06 release testing. cc: @beckernick this should be good to go once builds finish on the merge commit and are pushed to rapidsai-nightly.

@trxcllnt trxcllnt deleted the fix/cudf-column-ctor branch May 26, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trxcllnt @isVoid @harrism @bdice @taureandyernv