This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
[REVIEW] Fixing issue when reading sigmf data from parent folder #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
awthomp
approved these changes
Oct 30, 2020
|
@BradReesWork -- can you add Tom to the allowlist and |
BradReesWork
added
the
improvement
BradReesWork
approved these changes
Nov 11, 2020
|
ok to test |
|
Looks like the pr-builder didn't go thru. Seems like a test config problem |
|
rerun tests |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
@drabastomek - can you update the ChangeLog with your PR? |
|
rerun tests |
awthomp
added
improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to the
.read_sigmf(...)method to handle reading metadata file (whenmeta_filenot specified) from the parent folder that requires..escapes. Current solution does not handle this use case.Tested locally. No unit test written.
Closing [BUG] Error reading SigMf formatted file #279
Ready for review.
Ready for review.
Ready for review. No additional changes expected.