This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix filtering.resample output for even values of num parameter (#517)
This just fixes the handling of the nyquest frequency bins when resampling using the FFT method (`filtering.resample`). Without enforcing the fourier space be hermitian symmetric like this, the resampled output had a few undesirable properties: 1. It had a different integrated power spectrum than the input 2. It was not reversible i.e. `resample(resample(y, <larger size than y>), <original y size>) != y` 3. The output disagreed with `scipy.signal.resample`. The max error was around 1e-2 in my application. Thanks Authors: - Matt Kinsey (https://github.com/mattkinsey) - Ray Douglass (https://github.com/raydouglass) - gpuCI (https://github.com/GPUtester) - Adam Thompson (https://github.com/awthomp) - AJ Schmidt (https://github.com/ajschmidt8) - Mike Wendt (https://github.com/mike-wendt) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #517
- Loading branch information